Giter Club home page Giter Club logo

Comments (8)

jcvernaleo avatar jcvernaleo commented on June 19, 2024 1

Big +1 on no default behavior. As someone who runs a lot of core-geth nodes, I very much prefer changes that things break things immediately and loudly (like having no default chain) so that I'm never caught with something broken that I think works.

from core-geth.

meowsbits avatar meowsbits commented on June 19, 2024

Reiterating conversation from previous forum:


@meowsbits:

Doing this will require a Major version change. (https://semver.org/)

Eventually I want to decouple the program(s) from configuration defaults entirely.

But I see the reasoning for this now (since the project is largely supported by ETC-first backers), and think that if there's a time to do it, this seems like an OK one.

Noting also that we'll need to very careful with data directories...

Geth doesn't behave consistently or very predictably when managing FS structure with regard to -- settings (eg ethereum/go-ethereum#19172).


@soc1c:

Doing this will require a Major version change. (https://semver.org/)

We are already doing a major repository change. We are about to release a new client.

Releasing 1.10.0 would be sufficient. (Minor version change)

If we want to do some radical changes, let's not hesitate to do them now.

Because later will not happen


from core-geth.

meowsbits avatar meowsbits commented on June 19, 2024

Releasing 1.10.0 would be sufficient. (Minor version change)

Can you provide your reasoning here?

Because later will not happen

Ditto... reasoning?

from core-geth.

 avatar commented on June 19, 2024

Wondering if this is still an issue I can help with? ( You could assign me if you want :) )

from core-geth.

meowsbits avatar meowsbits commented on June 19, 2024

Hey, wow! thanks @cryptoasuka! At this point the question is primarily an API one. Changing default behavior is a BIG change, which makes me a little skittish on changing from one (inherited) opinion to another.

My preference would actually be to remove the ETH default, leaving no default, forcing the user to use some --<chain> flag.

from core-geth.

BelfordZ avatar BelfordZ commented on June 19, 2024

+1 to getting burned on this

from core-geth.

iquidus avatar iquidus commented on June 19, 2024

any preferences on flag naming for ethereum mainnet? --ethereum or --foundation ?

edit: faucet already uses 'foundation', will stick with this.

from core-geth.

iquidus avatar iquidus commented on June 19, 2024

update: staying inline with recent upstream additions, --mainnet will be used for ethereum mainnet.

initial phase (no chain flag warn) has begun, see: #319

from core-geth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.