Giter Club home page Giter Club logo

Comments (7)

dmoklaf avatar dmoklaf commented on August 26, 2024

It looks like this patch (my mistake) locked the wrong file descriptor.

Before the patch the file descriptor used was based on db.lockfile:
err := lockFileEx(syscall.Handle(db.lockfile.Fd()), flag, 0, 1, 0, &syscall.Overlapped{})

The patch factored it out of the loop, but based on db.file:
fd := db.file.Fd() ... err := lockFileEx(syscall.Handle(fd), flag, 0, 1, 0, &syscall.Overlapped{})

The file vs. lockfile subtlety seems to exist only on Windows, as the db struct definition tells.

I could happily patch it but I don't have anymore (and won't have for the coming months) a Windows platform to test it. But if you have one, let me know and we can do it together.

from bbolt.

kwf2030 avatar kwf2030 commented on August 26, 2024

I just modified bolt_windows.go at line 65, change fd := db.file.Fd() to fd := f.Fd() and it seems fixed @rgeronimi

from bbolt.

dmoklaf avatar dmoklaf commented on August 26, 2024

LGTM

from bbolt.

xiang90 avatar xiang90 commented on August 26, 2024

can you send a patch to fix this?

from bbolt.

kwf2030 avatar kwf2030 commented on August 26, 2024

@rgeronimi @xiang90 I have just create a pr #64

from bbolt.

xiang90 avatar xiang90 commented on August 26, 2024

fixed by #64

from bbolt.

dmoklaf avatar dmoklaf commented on August 26, 2024

Thks

from bbolt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.