Comments (5)
nixta
commented on July 29, 2024
1
Yeah, works much better. Nice work.
I think we should fix up the CSS before we release though. Seems the CSS from the old chosen library was just copied wholesale into our home.css and there isn't a proper match now. Should mostly be some overrides for the bubble sizes and backgrounds, and the chooser line height.
@alaframboise might have some insight here, but it was so long ago I wouldn't be surprised if that information has been flushed.
Cheers,
Nick.
from esri.github.io.
jgravois
commented on July 29, 2024
1
I must be a foreigner in this repo.
not anymore. you've earned the 🔑s
from esri.github.io.
jf990
commented on July 29, 2024
@nixta i was not able to tag you as a reviewer, can you test my branch and see if I addressed this? the UI is a bit different now but it seems to be something more intuitive.
from esri.github.io.
nixta
commented on July 29, 2024
Hmmm. I must be a foreigner in this repo. I can't assign myself, but I'll take a stab at updating the CSS.
from esri.github.io.
nixta
commented on July 29, 2024
PR #99 submitted.
from esri.github.io.
Related Issues (20)
- establish procedure to continually curate list of Search Topics HOT 9
- Add spinner when repo number is fetched
- remove custom search from mobile entirely? HOT 3
- Two buttons with same ID HOT 1
- Add new topics to landing page dropdown menu HOT 4
- Requested new high-level topics HOT 1
- write doc for Esri repo maintainers regarding topics
- Upgrading to Arcgis 4.12 throws an error: ERROR TypeError: Cannot read property '1' of undefined HOT 5
- Can't load RuntimeCoreNet.dll HOT 9
- don't redirect https://esri.github.io/#
- arrow input isn't handled appropriately *after* the user has entered text
- Use ellipsis character for "Search by topic..." placeholder
- Show matched search topic at top of topic dropdown
- Show feedback while GitHub API fetches result counts/errors
- input tag spellcheck="false" attribute for mac OS HOT 2
- D language probably not actually right to include in search options HOT 3
- add more user case study copy (e.g. "Smithsonian" or "U.S. Census Bureau"). HOT 5
- Add category and search term for Native Development
- Gibbs Seed showcase anchor incorrect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esri.github.io.