Giter Club home page Giter Club logo

Comments (4)

arcusfelis avatar arcusfelis commented on May 27, 2024

Not a high priority, it is very niche application.
Barely documented, not an official XEP.
PubSub for this is a bit of overengineering.
How would it behave with a long list of blocked users?

Besides, not many people expect MUC groupchats to be used in 2023.
Could be done later once we wanna invest time in spam detection infrastructure and logic (i.e. XEP-0377 or something custom). But again, we would probably have to evaluate usage with gigantic lists. Removing the spammer account could be preferable for installations, which do not use s2s. Also, integration with mod_privacy could be considered (but again, there is no clear usage model even for mod_privacy, which would fit the modern requirements).

from mongooseim.

Neustradamus avatar Neustradamus commented on May 27, 2024

@arcusfelis: It has been added in ejabberd since 23.04:

from mongooseim.

arcusfelis avatar arcusfelis commented on May 27, 2024

I know.
https://github.com/processone/ejabberd/blob/ffbcf19156b5808e0640193ee8439a9a01354c87/src/mod_muc_rtbl.erl

It is literally non-scalable. It uses broadcasts to ALL online MUC room processes on each pubsub update.
So, if list updates are too often it would lead to DDoS.

And it does not look like it will scale with large number of blocked items. With larger number of items we:

  • have to copy more data into into the room processes.
  • starting having scalability issues with the number of items inside of a single node in pubsub.

In the public environment it means that the spammer could register millions of spam accounts on a public server that allows it and we don't have control over that. And we would have to block the whole domain (which would block the regular users too) or not block them at all.

from mongooseim.

arcusfelis avatar arcusfelis commented on May 27, 2024

We could optimize kicking (so, no broadcasts to all rooms) but it still leaves us with the issue of the maximum number of items we can block over PubSub. Scalability characteristics of Pubsub is more interesting topic though. Can we write 1M items into a single node? Something to test first.

from mongooseim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.