Giter Club home page Giter Club logo

Comments (3)

eshaz avatar eshaz commented on August 16, 2024

I was able to reproduce the EventTarget issue, which I'll have a fix out for shortly.

As for AAC support, if it is not listed in the mapping, then your browser's Audio element cannot play back that format. HTML5 playback support for a format is determined by checking the Audio element canPlayType() method here. Support varies depending on your platform and browser. I would think iOS would have AAC support pre-installed, but that might not be the case for all versions / regions. There's nothing that can be done in this library to add AAC support to the Audio element if your browser doesn't support it.

Could you post a screenshot of what you see here in the supported codecs section?

from icecast-metadata-js.

Camelot22rus avatar Camelot22rus commented on August 16, 2024

I was able to reproduce the EventTarget issue, which I'll have a fix out for shortly.

As for AAC support, if it is not listed in the mapping, then your browser's Audio element cannot play back that format. HTML5 playback support for a format is determined by checking the Audio element canPlayType() method here. Support varies depending on your platform and browser. I would think iOS would have AAC support pre-installed, but that might not be the case for all versions / regions. There's nothing that can be done in this library to add AAC support to the Audio element if your browser doesn't support it.

Could you post a screenshot of what you see here in the supported codecs section?

Our radio responds in aac format, which is not supported in the canPlayType function of WebAudioPlayer.js, but in the Player.js:86 file, it checks not from canPlayType, but from supportedSources, which has WebAudioPlayer. As a result, in this function, WebAudio works for us, but in fact html5 player.

In the function EnablePlayButton (Player.js:86) in the conditions it is better to write not supportedSources.includes("mediasource"), supportedSources.includes("html5"), supportedSources.includes("webaudio"),
but MediaSourcePlayer.isSupported(), WebAudioPlayer.isSupported(), HTML5Player.isSupported()

Or enable aac in WebAudioPlayer.js mapping object

from icecast-metadata-js.

eshaz avatar eshaz commented on August 16, 2024

Can you try instantiating the player with the playbackMethod set to html5 and see if it will playback AAC?

Also, do the AAC streams work for you on the demo? There are three different demo pages. Could you try all three with an AAC stream and see if you can reproduce the issue?

from icecast-metadata-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.