Illegal backwards jump when decoding OpenSea function calls about headlong HOT 6 CLOSED

Specifically, they are reusing the same offset value (2848) for two distinct items (index 7 and index 8). I assume they are doing it intentionally (to save gas?), but it is best to be sure.

from headlong.

Problem solved. Many thanks!

The result of decoding OpenSea Contract from datawaves

from headlong.

A backwards jump (where the destination offset is less than the current offset) would indicate that bytes that have already been decoded should be decoded again, and for a different purpose. As a security precaution and sanity check, I have not been allowing this.

Could you contact the creator of the data to determine if they really intend to do this and if so, why?

from headlong.

I am glad you reply. I will contact the author to figure out what's the intention.

Should we consider relaxing the restriction only if the outcome is right? But I'm not sure whether it is a good choice from the API perspective. Maybe this case (reusing the same offset) is not very common.

We have some customers who are facing this issue. It begs the question: How can I patch the code to avoid the error? Maybe I can craft a patch to work around the problem temporarily.

from headlong.

I added a commit which should allow any number of elements to share the same offset, but which will not allow backwards jumps in other circumstances: e042a12

If you are able to test this change on the full dataset, please do.

In any case, I will most likely release a new version with this change included soon.

from headlong.

Cool! I will test it right now (I will come back if I get testing results). The patch looks great to me.

from headlong.