Footnotes incorrectly numbered? about parsedown-extra HOT 6 CLOSED

Confirmed.

I created PR #15 to fix this.

Hope this can help...

Regards,
Sergio

from parsedown-extra.

        usort($this->Definitions['Footnote'], function($A, $B) {
            return $A['number'] - $B['number'];
        });

in buildFootnoteElement() doesn't restore the name of named footnotes to the array.

from parsedown-extra.

No, the problem is that the footnote name is not saved at all and its "number" is used instead: please see my (amended) PR.

from parsedown-extra.

in buildFootnoteElement() on line 362, you just have to replace usort by uasort to preserve array keys.
Like that :

uasort($this->Definitions['Footnote'], function($A, $B) {
    return $A['number'] - $B['number'];
});

from parsedown-extra.

@delew You are absolutely right. I'm committing the fix.

from parsedown-extra.

Fantastic! I'm glad the correct solution has finally been found!

Congrats @delew !

from parsedown-extra.