Comments (15)
Hello @Riyabelle25,
As I mentioned, please first complete the requirements in issue #36. Then we advise you to choose one issue to start working with, either this one or issue #7 where you have also shown interest
from ersilia.
Hi @Riyabelle25 and @Amna-28 - I am slowly catching up.
You will see that I have a ModelFullDeleter
class in: https://github.com/ersilia-os/ersilia/blob/master/ersilia/hub/delete/delete.py This is the class that is called by the CLI command as well: ersilia delete ...
This is the right way to delete a model (@Riyabelle25 it will delete the local copy of the github repo indeed, among other things).
@Amna-28 I really like your cronjob approach, as you know. I have no experience in this, but perhaps we could try this python library? https://pypi.org/project/python-crontab/
from ersilia.
Hi @miquelduranfrigola can we do DVC on this issue to track the files and then remove it. I am still learning and searching to how make work remotely. Ease guide me :)
from ersilia.
Good points, @sonali-sk. Fetching a second time takes less time in this case, probably because conda has already cached some packages.
I do think that checking for the "last modified" data point in the repo would be a good way of avoiding unnecessary extra downloads. We haven't implemented it yet. Will keep you updated.
from ersilia.
Hi!
I have experience with Software Development for ML tools, and would love to contribute here! I have set up Ersilia and have been going through the codebase. Can I take this up?
from ersilia.
Hi!
I have completed the Ersilia installation and have run the model. I am really interested in this issue.
May I start working on this task?
from ersilia.
Hi @Amna-28 and @Riyabelle25! I see that both of you are showing interest in this task. Before implementing anything, I'd like to hear your thoughts, so that we are all on the same page (this issue may be a bit tricky to address). How would you like to approach this problem? (one or two lines will suffice :))
from ersilia.
Hi there!
First, could you tell us from where do we delete the unused model?
In my last issue, I observed that each model is fetched from its own repo: https://github.com/ersilia-os/eos6tg8
So is it desired to delete the git repo itself?
from ersilia.
I have been working on this task.
I have created a python script that uses python os and datetime to filter files that are not accessed for n days and deletes them and used cron job to automate the deletion after required interval.
I was searching and found that we can create cron job using shell script, but I am unsure about whether we could automate the creation of cronjob on another system.
still working on finding which specific directories to delete
@miquelduranfrigola please correct me if I am going in the wrong direction
from ersilia.
Hi @Rufaida98 this is a great suggestion. We will certainly use DVC in the context of model data management (https://github.com/ersilia-os/isaura), but I feel the current solution, with cron jobs is good enough, because models are not being updated or anything - they just need to be removed after some time.
from ersilia.
@miquelduranfrigola oh I see thank you for the feedback 👍
from ersilia.
Hi @miquelduranfrigola, I have a couple of doubts, If a model is already fetched and is in the local system,
- If we fetch the same model again, will the model's repo along with other related files be fetched again from git-lfs or from the local system?
- Also when we know that a model is already in the local system, should that model be fetched again or is it safe to go ahead serving?
Thanks.
from ersilia.
Hi @sonali-sk thanks for the two questions.
At the moment, by default when you fetch a model that is currently available in your system, the model is deleted and we fetch it again. We can certainly optimize this, perhaps just by using git functionalities.
from ersilia.
@miquelduranfrigola Is it being deleted so that the repo's last modify date is changed? Also, what I noticed initially is that when we try to fetch an already fetched model, it took lesser time compared to the current fetch mechanism, at that time was it fetching from the local system, due to which it took relatively less time?
from ersilia.
Hi folks:
I am closing this issue since we've done quite a lot of progress since May.
The fetch command is now, in principle, ready to allocate checkpoints.
from ersilia.
Related Issues (20)
- 🐈 Task: Remove PyAirtable as a hard dependency HOT 1
- 🐈 Task: Fix action that uploads Ersilia base image to DockerHub
- 🐈 Task: Bump requests and docker-py versions in ersilia
- 🐕 Batch: Maintain additional credentials' requirements within models HOT 1
- 🐈 Task: Docker build for ersilia-pack HOT 2
- 🐛 Bug: log file not found warning after using the track flags
- 🐛 Bug: Fetching models on MacBook (M1) results in 404 error due to looking for linux/arm64 HOT 1
- 🐕 Batch: Define Model Installs through a YAML file instead of a Dockerfile HOT 3
- 🐕 Batch: Resource monitoring with different input scenarios and systems HOT 2
- 🐛 Bug: Numpy versions conflicts HOT 2
- 🐛 Bug: Tracking functionality does not work when a result CSV file is not specified
- 🐛 Bug: Performance Metrics Fail for String Output Model HOT 4
- 🐛 Bug: Ersilia close when model serving is interrupted HOT 2
- 🦠 Model Request: Cardiotoxicity Classifier HOT 13
- 🦠 Model Request: Demo Malaria Model HOT 8
- 🦠 Model Request: Predict bioactivity against Main Protease of SARS-CoV-2 HOT 22
- 🦠 Model Request: Unit Test Model Compound HOT 3
- 🦠 Model Request: QupKake: predict micro-pKa of organic molecules HOT 28
- 🐈 Task: Remove dead code from ersilia
- 🐈 Task: Inconsistency between current licenses recognized by Ersilia vs those maintained in Airtable HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ersilia.