Giter Club home page Giter Club logo

Comments (10)

knoopx avatar knoopx commented on May 28, 2024

However it works perfectly in Firefox

from errbit.

akzhan avatar akzhan commented on May 28, 2024

Just send Prq with update of UJS to latest version. #73

You can apply that patch to check is it fixes your issue.

from errbit.

ndbroadbent avatar ndbroadbent commented on May 28, 2024

Cheers for the pull request. Don't have any reason not to accept it, but would like to hear if it fixes @knoopx's issue first

from errbit.

ndbroadbent avatar ndbroadbent commented on May 28, 2024

Hey @knoopx, I have tested the 'resolve' buttons in both Chrome and Chromium, and they work fine for me. Can you confirm that this is also broken on a different instance of Chrome, i.e. on another computer?

from errbit.

akzhan avatar akzhan commented on May 28, 2024

@knoopx, please write your system/browser information if patch doesn't help you.

from errbit.

akzhan avatar akzhan commented on May 28, 2024

As described in #73, has been partially solved (one of Chrome user plugins disables confirmation dialog).

Really we need replacement for confirm() that will be safe.

from errbit.

ndbroadbent avatar ndbroadbent commented on May 28, 2024

Do you have any suggestions for a safe replacement? I'm not very familiar
with dealing with 'safe' dialogs..

from errbit.

akzhan avatar akzhan commented on May 28, 2024

I'll try to write "safe confirm" using jQuery modal dialogs. Technically we need another branch of UJS, so I'll work on that.

Update: we need simply more customizable UJS. Will do.

from errbit.

akzhan avatar akzhan commented on May 28, 2024

First step complete and waiting for review in jquery-ujs.

rails/jquery-ujs#196

from errbit.

ndbroadbent avatar ndbroadbent commented on May 28, 2024

Fixed with #115

from errbit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.