Giter Club home page Giter Club logo

Comments (3)

erosson avatar erosson commented on August 22, 2024

I've added https://sentry.io/ tracking for exception/console.error/console.warn . Maybe the missing icons log a warning - they certainly do when I deliberately misspell them - and it's good to have this tracking anyway.

bc5f6f1 276abe5 5ada3fb de59d97 a01df10 82c8f9a

from freecbt.

erosson avatar erosson commented on August 22, 2024

rollback until it works (in the testflight channel); find where it broke

git bisect made this pretty easy/mindless! yarn && expo publish --release-channel dev ; close and re-open the testflight ios app; see if it has icons; git bisect [good|bad], repeat 5 times. from there, see what deps changed in that commit and try them all.

I have no idea why expokit is required for ios icons - isn't it only required once you eject? Regardless, I removed it earlier, and adding it back fixes ios icons.

This was broken since June 4, 8pm

b774d6b607fc9be7e70a30735ea4214c3966161c is the first bad commit
git bisect start
# good: [2d76f6743701ffa5df1c5a784e4a9453270eb7c0] oops, formatting
git bisect good 2d76f6743701ffa5df1c5a784e4a9453270eb7c0
# bad: [fceba1476b3f7233d34beec9f1b7c071a00753ac] ugh just build already
git bisect bad fceba1476b3f7233d34beec9f1b7c071a00753ac
# bad: [9adbb9e4fef7974e4ac7ebd777bbf30a7163769a] Merge pull request #25 from erosson/dependabot/bundler/ios/fastlane-2.149.1
git bisect bad 9adbb9e4fef7974e4ac7ebd777bbf30a7163769a
# good: [149d07fe247095da58e8e53bd55428d010642341] linter/formatter now correctly check all files
git bisect good 149d07fe247095da58e8e53bd55428d010642341
# good: [149d07fe247095da58e8e53bd55428d010642341] linter/formatter now correctly check all files
git bisect good 149d07fe247095da58e8e53bd55428d010642341
# bad: [2164a8bca1c1136d3e40f2d707fd8c99b25357a9] cleanup peer deps, #22
git bisect bad 2164a8bca1c1136d3e40f2d707fd8c99b25357a9
# bad: [d97bd44e373af96082056fb0cfcf64b1da02b074] upgrade prettier. #22
git bisect bad d97bd44e373af96082056fb0cfcf64b1da02b074
# bad: [5ff1d8568f906fe712ff96533651a55a9303dffe] all the easy package upgrades/removals. #22
git bisect bad 5ff1d8568f906fe712ff96533651a55a9303dffe
# bad: [b774d6b607fc9be7e70a30735ea4214c3966161c] more easy version bumps #22
git bisect bad b774d6b607fc9be7e70a30735ea4214c3966161c
# first bad commit: [b774d6b607fc9be7e70a30735ea4214c3966161c] more easy version bumps #22

from freecbt.

erosson avatar erosson commented on August 22, 2024

fix confirmed 🎉

from freecbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.