Custom rebar3 shells cannot pass args when using Erlang 26 about rebar3 HOT 7 CLOSED

As for docs, it looks like I would need to update these:

• The user_drv_args entry in rebar_prv_shell's opts
• https://github.com/tsloughter/rebar3.org/blob/master/content/en/docs/commands.md

from rebar3.

Yep, sorry. I've just manually allowed the run, always manual mode until a contrib is merged apparently.

from rebar3.

Yeah looking at it, and since the default shell_args argument is [], the apply/3 form might work fine. The doc does need updating, and if you're submitting a PR, I'll merge it ASAP since it seems the args had been changed a while ago.

The only risk with the apply/3 form is ending up with an undef error, which would mean the list of arguments given was invalid. The other slight risk there is that it's possible at some point the two formats for ShellArgs could start changing between versions, and keeping compatibility would be a challenge, all pushed onto plugin writers.

If the latter risk seems acceptable to you (the target audience for this option set) then I think we're good with the proposed implementation.

from rebar3.

Nice -- Thanks!

I'll update the docs and take the PR out of draft.

from rebar3.

Btw, the GH Actions CI/CD that need to run for this PR, only the most recent should be run -- that's the one that has the update for the dialyzer ignore (arity change).

from rebar3.

I merged it, but I'm just noticing now that I'm looking at the doc PR that we fetch the config from shell_args but allow the config value to be user_drv_args How are we actually wiring these two arguments together? How has this ever worked?

Oh I guess one is the CLI option and one is the state option?

from rebar3.

Oh I guess one is the CLI option and one is the state option?

That is my understanding, yes. (this trips me up every couple of years when I dive into this part of the code ...)

from rebar3.