Giter Club home page Giter Club logo

Comments (5)

eriklindernoren avatar eriklindernoren commented on May 1, 2024
  • I decided to implement the Adaboost algorithm with decision stumps (one-level decision tree) since this version of Adaboost tends to perform well out-of-the-box. This is from the Wikipedia page of Adaboost: "While every learning algorithm will tend to suit some problem types better than others, and will typically have many different parameters and configurations to be adjusted before achieving optimal performance on a dataset, AdaBoost (with decision trees as the weak learners) is often referred to as the best out-of-the-box classifier." The classifiers will however not be "the same" as they will classify samples based on different feature values and different threshold values. The classifiers that are more accurate on the training data will have greater impact on the final prediction of the test sample (more accurate => higher alpha value).
  • The reason that y_pred is concatenated in predict is so that the classifier's prediction are of y are added as columns (so column i represents the predictions of y for classifier i). These columns are weighted by the classifier's alpha value, which like i described in my answer to your first questions represents how much impact this classifier will have on the final prediction of y. These columns are then summed, and y is then classified as the sign value.
    From Wikipedia: "For example in the two class problem, the sign of the weak learner output identifies the predicted object class and the absolute value gives the confidence in that classification. Similarly, the {\displaystyle T} Tth classifier will be positive if the sample is believed to be in the positive class and negative otherwise."

Hope this answers your questions.

from ml-from-scratch.

whcn avatar whcn commented on May 1, 2024

In line 95, w = w.dot(np.exp(clf.alpha * y.dot(predictions))). I think this line of code is plan to update weight of data points. In theory, we assign smaller values to hit points, and higher values to miss points. But np.exp(clf.alpha * y.dot(predictions)) is scalar, i.e. numpy.float64, it means that all weights still be same after updating.

from ml-from-scratch.

eriklindernoren avatar eriklindernoren commented on May 1, 2024

Ah, you're right. w is never assigned higher values for misclassified samples and lower for correctly classified samples. The problem was not using np.exp (which calculates the exponential of all elements in the input array and returns the resulting array) however, but the exponent. The problem was that I calculated the dot product instead of calculating the hadamard product.
Changing it to the following line fixed this issue:
w *= np.exp(-clf.alpha * y * predictions)

Thank you for pointing this out. This is resolved in the latest commit.

from ml-from-scratch.

hisabness avatar hisabness commented on May 1, 2024

from ml-from-scratch.

eriklindernoren avatar eriklindernoren commented on May 1, 2024

@hisabness you can change notification preferences for repositories that you're watching in Personal Settings -> Notifications.

Some additional information here:
https://help.github.com/articles/about-notifications/

from ml-from-scratch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.