Giter Club home page Giter Club logo

Comments (3)

jonathan-eq avatar jonathan-eq commented on June 2, 2024

We should add to the test that it asserts the process is actually running/was submitted correctly

from ert.

sondreso avatar sondreso commented on June 2, 2024

Failed again here: https://github.com/equinor/ert/actions/runs/7741442276/job/21108609982?pr=7072

__________ test_subprocesses_live_on_after_ert_dies[using_job_queue] ___________
[gw2] darwin -- Python 3.10.13 /Users/runner/hostedtoolcache/Python/3.10.13/x64/bin/python

tmp_path = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte0')
try_queue_and_scheduler = None

    @pytest.mark.scheduler
    @pytest.mark.integration_test
    async def test_subprocesses_live_on_after_ert_dies(tmp_path, try_queue_and_scheduler):
        # Have ERT run a forward model that writes in PID to a file, then sleeps
        # Forcefully terminate ERT and assert that the child process is not terminated
        create_ert_config(tmp_path)
    
        ert_process = subprocess.Popen(["ert", "test_run", "ert_config.ert"], cwd=tmp_path)
        check_path_retry, check_path_max_retries = 0, 50
        expected_path = Path(tmp_path, "test_out/realization-0/iter-0/forward_model_pid")
        while not expected_path.exists() and check_path_retry < check_path_max_retries:
            check_path_retry += 1
            await asyncio.sleep(0.5)
    
>       assert expected_path.exists()
E       AssertionError: assert False
E        +  where False = <bound method Path.exists of PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte0/test_out/realization-0/iter-0/forward_model_pid')>()
E        +    where <bound method Path.exists of PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte0/test_out/realization-0/iter-0/forward_model_pid')> = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte0/test_out/realization-0/iter-0/forward_model_pid').exists

tests/integration_tests/scheduler/test_integration_local_driver.py:54: AssertionError
__________ test_subprocesses_live_on_after_ert_dies[using_scheduler] ___________
[gw2] darwin -- Python 3.10.13 /Users/runner/hostedtoolcache/Python/3.10.13/x64/bin/python

tmp_path = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte1')
try_queue_and_scheduler = None

    @pytest.mark.scheduler
    @pytest.mark.integration_test
    async def test_subprocesses_live_on_after_ert_dies(tmp_path, try_queue_and_scheduler):
        # Have ERT run a forward model that writes in PID to a file, then sleeps
        # Forcefully terminate ERT and assert that the child process is not terminated
        create_ert_config(tmp_path)
    
        ert_process = subprocess.Popen(["ert", "test_run", "ert_config.ert"], cwd=tmp_path)
        check_path_retry, check_path_max_retries = 0, 50
        expected_path = Path(tmp_path, "test_out/realization-0/iter-0/forward_model_pid")
        while not expected_path.exists() and check_path_retry < check_path_max_retries:
            check_path_retry += 1
            await asyncio.sleep(0.5)
    
>       assert expected_path.exists()
E       AssertionError: assert False
E        +  where False = <bound method Path.exists of PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte1/test_out/realization-0/iter-0/forward_model_pid')>()
E        +    where <bound method Path.exists of PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte1/test_out/realization-0/iter-0/forward_model_pid')> = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_subprocesses_live_on_afte1/test_out/realization-0/iter-0/forward_model_pid').exists

tests/integration_tests/scheduler/test_integration_local_driver.py:54: AssertionError

from ert.

eivindjahren avatar eivindjahren commented on June 2, 2024

More failures here:

from ert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.