Ert unit_tests/gui/test_main_window.py::test_that_gui_plotter_works_when_no_data fails and seems flaky about ert HOT 5 CLOSED

It was most recently observed failing on Azure, but might also be onprem.

from ert.

yes, it just failed onprem as well https://github.com/equinor/komodo-releases/actions/runs/7708557631/job/21009909965

from ert.

Failed on-prem here: https://github.com/equinor/komodo-releases/actions/runs/7737308845/job/21097190440

from ert.

Found the problem. When it is running alongside unit_tests/gui/test-main_window.py::test_that_the_plot_window_contains_the_expected_elements, it will somehow share storage. That test runs esmda and asserts it finds 5 cases in the result, while the other test is failing because it is finding 5 cases while expecting 0 cases. The next issue is seeing why this it happening.

from ert.

Solution: PlotApi uses the StorageService.session, which seems to be a singleton across tests when they are running simultaneously. Fixed by mocking the PlotApi._get_all_cases method in the test.

from ert.