Comments (7)
I'll have a look at it. Note on the side, you can write -vvv
instead of -v -v -v
. I assume you were using the 1.7.0?
from sina.
Thanks :) Yes, I used 1.7.0 but also tried 1.6.1 and 1.2.11 and the classification result was the same with all versions (did not check the nearest neighbors in details with the old versions, though).
from sina.
mind if I add the example to the unit tests?
from sina.
Simple enough. Classic int/float truncation issue. Should work now. I'm pushing 1.7.1, should be in bioconda within a day or so.
from sina.
mind if I add the example to the unit tests?
No, go ahead.
The submitted fix only fixes the difference between the second and third execution. The problem that the first test case
./sina -i aligned.query.fasta --prealigned --fs-kmer-no-fast --search --search-db SILVA-no-fields-reduced.opt.arb --search-kmer-len 10 --search-min-sim 0.95 --lca-quorum 0.8 --search-no-fast --lca-fields tax_slv -vvv
returns Archaea;Halobacterota;
instead of Archaea;Halobacterota;Methanomicrobia;Methanomicrobiales;Methanomicrobiaceae;Methanoculleus;
despite 8 of the 10 top hits having the latter classification is still present in 1.7.1.
from sina.
Darn - didn't see that part. Case of TL'DR I suppose.
from sina.
You are correct in your observation. The algorithm does an LCA between the best match and the others. Guess that was usually so close to what it's supposed to do that no-one notices. This will take me a day or two to fix. Don't have enough time in the evenings.
from sina.
Related Issues (20)
- Problems installing sina on macOS Big Sur HOT 1
- Failing to load db index HOT 4
- error while loading shared libraries: libtbb.so.2 HOT 6
- Support arb 7.0
- Compile issue on Debian 10 (linker command line)
- Problem building / installing documentation on Debian 10
- libboost library conflict with qiime2 HOT 3
- sina not working within a docker container HOT 2
- Terminatin with signal 11 error HOT 2
- SINA not processing fasta files that have been filtered using vsearch HOT 2
- sina keeps rebuilding pt-server from scratch HOT 2
- Sina does not actually output LCA classification anymore? HOT 3
- Implement banded alignment
- Base shift in copied alignment HOT 3
- How could I calculate identity between two 16S rDNA sequence? HOT 1
- necessary fields for "-f" not stated correctly in documentation, and also not given by "--arb-list-fields"? HOT 1
- Custom ARB database has no taxonomy fields HOT 1
- build failure ‘tbb_allocator’ is not a member of ‘tbb’ HOT 8
- --add-relatives outputs unexpected sequence ID HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sina.