Giter Club home page Giter Club logo

Comments (11)

vandalon avatar vandalon commented on May 18, 2024 1

When using the slider, there is still an input box, so you have both options, that's why I like it :)
Using the step value makes it easy to make precise tuning possible :)

from awesome-ha-blueprints.

vandalon avatar vandalon commented on May 18, 2024 1

Interesting idea! This requires to add additional inputs to the Media Player Hook, hence we might consider it later as a separate feature. For now I think we can keep it simple and only update configuration for existing inputs. :)

Actually i have an idea that would not need extra inputs. Will try and make something for that later :)

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

Hi @vandalon, thank you for the suggestion. :)

When developing these blueprints for the first time I was worried that using sliders might worsen the usability of the user interface, especially if you have to finely tune an input value and the range is quite large.

How's the user experience of such visual controls on a phone or tablet in your opinion? Are you able to precisely tune blueprint numeric inputs?

Moreover, I noticed an interesting idea you used in your contributions: increasing the step value for inputs such as delays etc. where a precise value is not required. Increasing the step value would reduce the number of steps in the slider and improve usability. Definitely something which we should consider. :)

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

Definitely a good choice then.πŸ‘πŸ»

Maybe before starting working on this improvement we should group here the numeric inputs which need to be changed - and propose the new step value for them.
This way once we have the PR we can merge it without having to discuss changes. :)
What do you think about it?

from awesome-ha-blueprints.

vandalon avatar vandalon commented on May 18, 2024

sounds good to me :)

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

Ok so, here are numeric inputs I found on existing blueprints, and my proposal for the new step values for them:

  • Controllers:
    • helper_double_press_delay: 50
  • Light Hook:
    • light_transition: 50
    • min_brightness: 1
    • max_brightness: 1, I'd change the min value to 1
    • brightness_steps_short: 1
    • brightness_steps_long: 1
    • on_brightness: 1, I'd change the min value to 1
  • Media Player Hook:
    • volume_steps_short: 1
    • volume_steps_long: 1

Let me know what you think. :)

from awesome-ha-blueprints.

vandalon avatar vandalon commented on May 18, 2024

All nr inputs that have a min and max defined would qualify no? :)
i would set transition to 100ms even 50ms is really not noticeable i think.
brightness values should be 1, I agree
short brightness steps of 1 are also not noticeable. I would say at least 5 there.
on_brightness also agreed :)

For media volume i have another idea because the problem with audio is that small steps matter when the volume is low, but small steps on higher volume are not noticeable. I did the following in my automation:

                  volume_level: >-
                    {% set volume_step %} {% if
                    state_attr("media_player.woonkamer","volume_level") < 0.05
                    %}0.01 {% elif
                    state_attr("media_player.woonkamer","volume_level") < 0.12
                    %}0.03 {% else %}0.05{% endif %} {% endset %} {{ [
                    state_attr("media_player.woonkamer","volume_level") +
                    volume_step | float ,0.8 ] | min  }}

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

All nr inputs that have a min and max defined would qualify no? :)

Yes :)

i would set transition to 100ms even 50ms is really not noticeable i think.

I agree on setting transitions steps to 100ms, but we also have to take care of the default value for some of them (currently 250, should be increased to 300).

brightness values should be 1, I agree
short brightness steps of 1 are also not noticeable. I would say at least 5 there.

I'd prefer to leave this to 1. Users might need to set a really low value since not all lights react at the same way, and some of them might need a finer control (especially really powerful lights).

on_brightness also agreed :)

For media volume i have another idea because the problem with audio is that small steps matter when the volume is low, but small steps on higher volume are not noticeable. I did the following in my automation:

                  volume_level: >-
                    {% set volume_step %} {% if
                    state_attr("media_player.woonkamer","volume_level") < 0.05
                    %}0.01 {% elif
                    state_attr("media_player.woonkamer","volume_level") < 0.12
                    %}0.03 {% else %}0.05{% endif %} {% endset %} {{ [
                    state_attr("media_player.woonkamer","volume_level") +
                    volume_step | float ,0.8 ] | min  }}

Interesting idea! This requires to add additional inputs to the Media Player Hook, hence we might consider it later as a separate feature. For now I think we can keep it simple and only update configuration for existing inputs. :)

Thank you for your feedback! I'm proceeding with implementing the suggested changes. :)

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

If you agree i'm happy to make a pull request for this :)

@vandalon I'm sorry, I confused this issue with the one you left me a few days ago. :D
Are you going to work on this too? Just let me know. :)

Thanks!

from awesome-ha-blueprints.

vandalon avatar vandalon commented on May 18, 2024

If you agree i'm happy to make a pull request for this :)

@vandalon I'm sorry, I confused this issue with the one you left me a few days ago. :D
Are you going to work on this too? Just let me know. :)

Thanks!

Go right ahead:) i had my hands full on the 2 controllers and the ha bug πŸ˜€

from awesome-ha-blueprints.

EPMatt avatar EPMatt commented on May 18, 2024

Go right ahead:) i had my hands full on the 2 controllers and the ha bug πŸ˜€

Great, thank you. :)

from awesome-ha-blueprints.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.