Comments (5)
Arno500
commented on May 18, 2024
1
I can now confirm everything is working as expected, filenames are respected, and console output in Powershell is still garbled 😃 (as expected too, since Lucida Console doesn't support Kanji I think).
EDIT : Long live UTF-8 everywhere ! (hoping Microsoft makes something for it)
from freac.
Arno500
commented on May 18, 2024
Oh, and I also tried your latest build from the 20190610 (from the issue #39), but it was before your file encoding modifications to your smooth library. And you don't provide a lot of informations to build Fre:ac on windows, so I kind of dropped it.
from freac.
enzo1982
commented on May 18, 2024
Well, it works for me, see this screenshot made with freaccmd 20190423:
This is using the new Windows Terminal preview app which is the first to really support Unicode. It works with the regular console too, but you will not be able to input Japanese characters there. You can use tab completion, which will print placeholders for the CJK characters but still pass the correct file name to fre:ac.
fre:ac still prints ??? when processing the file, but processes it correctly. I'll see if I can fix the output to print in Unicode mode.
So if this doesn't work for you, something else must be wrong on your end.
from freac.
Arno500
commented on May 18, 2024
In fact, I was calling it from a PowerShell script. It loops over every
file in my folder and convert them to Opus. I tried manually converting the
files (still from the PowerShell console) to no avail. Also tried the new
Windows Terminal.
I also tried to set the console to UTF8 by hands.
Note that the file are perfectly processed by other utilities.
I'm starting to think there is a compatibility problem with PowerShell.
Le dim. 7 juil. 2019 à 23:47, Robert Kausch <[email protected]> a
écrit :
… Well, it works for me, see this screenshot made with freaccmd 20190423:
[image: 2019-07-07 233733]
<https://user-images.githubusercontent.com/7796713/60774172-a87fb080-a110-11e9-82c0-d62c10cc1767.png>
This is using the new Windows Terminal preview app which is the first to
really support Unicode. It works with the regular console too, but you will
not be able to input Japanese characters there. You can use tab completion,
which will print placeholders for the CJK characters but still pass the
correct file name to fre:ac.
fre:ac still prints ??? when processing the file, but processes it
correctly. I'll see if I can fix the output to print in Unicode mode.
So if this doesn't work for you, something else must be wrong on your end.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41?email_source=notifications&email_token=ABOY76XWYRX7PLASOULWHVLP6JP5RA5CNFSM4H6VX4P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLTW3Q#issuecomment-509033326>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOY76QTVZNBH5NYTKGK5DDP6JP5RANCNFSM4H6VX4PQ>
.
from freac.
enzo1982
commented on May 18, 2024
I just pushed a commit with a few fixes. Unicode I/O on the Windows console should work as expected now:
I also prepared a build for you to test: freac-1.1-alpha-20190708-windows-x64.zip
fre:ac actually was not getting passed Unicode file names on the command line, due to using the non-Unicode command line argument passed to WinMain. Unicode characters were passed as ? causing them to be interpreted as wildcards. That's why it still worked for me when I first tried. fre:ac just coincidentally found the correct file using the wildcard pattern.
The fix is to use the GetCommandLineW() function instead to get a Unicode version of the command line.
The console output issue was due to using the default ANSI codepage and was easily fixed by switching to UTF-8 with SetConsoleOutputCP().
from freac.
Related Issues (20)
- Window doesn't vertically fit on screen HOT 2
- Windows 11, Where are the CODECS stored? I want to add faac-1.29.9.2-win64 HOT 2
- fre:ac converting in flac locked to 32-bit only
- Ignored option "Clear album artist field if it matches track artist" if disabled HOT 1
- It does not copy the source folder structure.
- CPU cycles going to 100%, Freac freezes HOT 4
- Hard Crash When Opening the Program HOT 1
- Autostart ripping not working
- AAC High Efficiency v2 crashes when encoding mono audio files HOT 1
- Placeholders for improved output patterns
- Cmd, how to suppress the Warning: APIC ID are not supported, core count can be wrong if SMT is disabled...
- Log file: "total duration" figure loses the hours. HOT 1
- Freac crashes on Mac OS Ventura 13.6.3 when loading a cd HOT 4
- Add Afterburner option for FDK AAC HOT 2
- "delete origional files" option is not checked when switching to another profile HOT 1
- all sound files deleted
- Only the first 10 seconds are converted
- ConvertTicksToTimestamp(ticks) HOT 3
- Dot not recognised
- <length> does not work as place holder
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freac.