Giter Club home page Giter Club logo

Comments (10)

enty8080 avatar enty8080 commented on May 23, 2024 1

Okay, I'll take a look on it in a sec

from seashell.

enty8080 avatar enty8080 commented on May 23, 2024

@MannuVilasara Do we need to have 10/10? What's the point of linting? The code is formatted following the PEP8 guidelines, I am not aware of other standards.

from seashell.

MannuVilasara avatar MannuVilasara commented on May 23, 2024

@MannuVilasara Do we need to have 10/10? What's the point of linting? The code is formatted following the PEP8 guidelines, I am not aware of other standards.

Yea not really a need but just a suggestion. Can be used while creating workflows

from seashell.

enty8080 avatar enty8080 commented on May 23, 2024

@MannuVilasara What command did you run in pylint?

My rating is 8.94/10. Command: pylint seashell

from seashell.

MannuVilasara avatar MannuVilasara commented on May 23, 2024
pylint $(git ls-files '*py')

from seashell.

enty8080 avatar enty8080 commented on May 23, 2024

I guess you need to run pylint seashell to check whole module.

from seashell.

MannuVilasara avatar MannuVilasara commented on May 23, 2024

Won't it just check for just the seashell file present in bin

from seashell.

enty8080 avatar enty8080 commented on May 23, 2024

No, because you are running pylint on a seashell directory (from the root of this repository). It checks for all files located in seashell

from seashell.

MannuVilasara avatar MannuVilasara commented on May 23, 2024

No, because you are running pylint on a seashell directory (from the root of this repository). It checks for all files located in seashell

Yea it seems like it. Got the result to be 7.9 now.

from seashell.

enty8080 avatar enty8080 commented on May 23, 2024

IDK why did you get different result. What is your python version? I guess this might be the reason (mine is 12)

P.S. Anyway, I am currently working on a Pwny official release, so fixing linting problems is not in the plan yet. However, I might take a look at it in the future. Code quality and readability is an essential part.

from seashell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.