Giter Club home page Giter Club logo

Comments (4)

dpinte avatar dpinte commented on May 13, 2024

@smallnamespace when needed, we have been using classmethods to do the dispatching to the appropriate C++ constructor. It is not a clear policy over the library so far but we should more than likely go that route.

One example: https://github.com/enthought/pyql/blob/master/quantlib/termstructures/yields/rate_helpers.pyx#L118

from pyql.

smallnamespace avatar smallnamespace commented on May 13, 2024

@dpinte It looks like QL has a MakeSchedule helper class, but it 1) doesn't really fulfill a need in Python and 2) doesn't expose the vector<Date> parameter.

Would you prefer:

  1. An additional @classmethod on the Cython Schedule class
  2. A backwards-compatible change to the __init__ method (add dates to the end of the parameter list, and manually dispatch to the correct C++ constructor)

from pyql.

dpinte avatar dpinte commented on May 13, 2024

@smallnamespace I would suggest going for a classmethod.

from pyql.

smallnamespace avatar smallnamespace commented on May 13, 2024

@dpinte Thanks for the feedback, PR at #113

from pyql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.