Reduce the packaged size of the library about address-encoder HOT 55 CLOSED

Merged #31, bringing the size to 440,007.

from address-encoder.

hey, @Arachnid I have made a very good PR and hope it helps!

I got rid of what was taking almost 33% for nothing!

I hope I get paid asap thank you : )

ask me if there is any changes to do too!

there are more improvements to do too ( to make it smaller)

thanks

from address-encoder.

Now at 3,009,838 after #27. @jay-dee7 if you submit work, I will pay out 1.0909 Ether for your contribution.

Edit: It appears I can't pay a bounty out in parts. I'll update the original post to keep track of amounts owed, and pay out as soon as work seems to have stalled.

from address-encoder.

On my machine, current head is 2,983,989. I've updated the planned payout accordingly.

from address-encoder.

I've updated the PR also added a check for size in travis config as well

from address-encoder.

@x5engine you've done a good job by splitting it, but can you please rebase your PR from master and update it? it seems we have merge conflicts and further you can replace bs58check with your hextronweb package and save a whooping 86KB. PS: i removed TronWeb package all together in favor of bs58check but it seems that your package is just ~9 KB, so let's go with it.

from address-encoder.

Never mind, I understand.

If you need to publish a new package for this:

1. Please name it something like [cryptocurrency]-address-encoder so others can use it too.
2. Lock it to a specific published version in package.json.

from address-encoder.

What I did:

• Applied the latest changes from @jay-dee7
• Forked the package "sha.js", removed all hashes except sha256 since it's the only one being used.
• Forked "crypto-add-codec" from @jay-dee7 and referenced the modified shajs package.
• Changed 'cashaddrjs' package for a more compact script which doesn't requires a biginteger lib.

436,035 -> 394,170 (9,61% decreased file size)

from address-encoder.

Thank you for your hard work! I've paid out for the work so far, and will reopen the bounty for any new optimisations.

from address-encoder.

Thank you 😊

Was a real pleasure and congrats to you guys @jay-dee7 @inspireme6 for you work

from address-encoder.

@jay-dee7 thanks for your clarify, I don't need the reward, just sharp the codebase asap.

from address-encoder.

@inspireme6 Merged your PR #37 and updated the table!

Thanks @Arachnid! 🎉 btw according to the formula it should be 0.6729 not 0.6307 😅

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 8.0 ETH (2107.34 USD @ $263.42/ETH) attached to it as part of the ensdomains fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $91,226.47 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 weeks, 5 days from now.
Please review their action plans below:

1) futurebank-team has started work.

I love that kind of challenge, it would be an honor to work on this issue.
2) jay-dee7 has started work.

I''ll try to remove all the bloat and make it light
3) davidbanu has started work.

Would love to take part in this
4) x5engine has started work.

let me try something to get it way smaller
5) jasondrogo has started work.

Will deliver it with full requirements
6) inspireme6 has started work.

Removed a huge library that took more than 1mb.
7) abeseba has started work.

payout = (log2(size_before_pr) - log2(size_after_pr)) * 1 ether
8) dominik144 has started work.

100000000000000000000000000000000
9) dominik144 has started work.

100000000000000000000000000000000

Learn more on the Gitcoin Issue Details page.

from address-encoder.

How do i resubmit work ? I'll raise another pr in few hours

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 8.0 ETH (1835.8 USD @ $229.47/ETH) has been submitted by:

1. @jay-dee7
2. @x5engine
3. @inspireme6

@Arachnid please take a look at the submitted work:

• PR by @inspireme6
• PR by @x5engine
• PR by @jay-dee7

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $84,063.00 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.

@Arachnid just a dummy question, what would i have to do, to be part of the ens organization?

from address-encoder.

@jay-dee7 Everyone who is part of the organisation has a full- or part- time paid contracting arrangement with us. We're definitely open to hiring more talented engineers, but our budget is pretty limited at the moment.

from address-encoder.

@Arachnid just as a confirmation, are we supposed to create separate packages? like specific npm package for this project?

from address-encoder.

Hey @jay-dee7 thank you 😊

Well this is just a start and I can improve so much to make it so smaller and faster!

I think an independent package is a good way so it can be used in other packages but if it's not optimum we can have all the encoders in one place a folder here.

So @Arachnid what do you think? Tell me and I can get this under 300kB ;)

from address-encoder.

@jay-dee7 Not sure what you mean? There's already an NPM package for this project; we're just looking for size reductions of the existing package.

from address-encoder.

Okay sounds good I will do that and create a package with the correct name for the right encoder. and lock it on the package.json

from address-encoder.

Hey guys, I reduced the lib size by 62.27% just by removing the polkadot library :)

From 1,956,940 -> 738,548

from address-encoder.

@inspireme6 Amazing work! I've updated the list of pending payouts at the start.

from address-encoder.

@arachind I've added a new PR with slight changes and further size reduction

from address-encoder.

Really nice work from both of you! I've left some comments on #31 about some prerequisites before we can pull in a library with code from many places.

from address-encoder.

@Arachnid I got 1085093

#33

update: 458358

update2: 443961

update3: 396922

from address-encoder.

@Arachnid i think size of the lib has been reduced by a fair amount so far and i'm not sure if i'll be able to participate actively anymore. (will always keep an eye tho).
By what time can i expect the bounty to be paid out?

from address-encoder.

⚡️ A tip worth 2.45920 ETH (561.65 USD @ $228.39/ETH) has been granted to @inspireme6 for this issue from @Arachnid. ⚡️

Nice work @inspireme6! Your tip has automatically been deposited in the ETH address we have on file.

• $76132.79 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from address-encoder.

⚡️ A tip worth 1.40580 ETH (321.07 USD @ $228.39/ETH) has been granted to @jay-dee7 for this issue from @Arachnid. ⚡️

Nice work @jay-dee7! Your tip has automatically been deposited in the ETH address we have on file.

• $76132.79 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

• Arachnid tipped 1.4058 ETH worth 321.07 USD to jay-dee7.
• Arachnid tipped 2.4592 ETH worth 561.65 USD to inspireme6.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $74,305.68 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.

Thank you for your hard work! I've paid out for the work so far, and will reopen the bounty for any new optimisations.

@Arachnid i think you paid my reward to @inspireme6

from address-encoder.

Thank you for your hard work! I've paid out for the work so far, and will reopen the bounty for any new optimisations.

@Arachnid i think you paid my reward to @inspireme6

yea, I was going to say that lol. I'll tip you the whole amount from gitcoin.

from address-encoder.

sure @inspireme6 🥇

from address-encoder.

sure @inspireme6

okay just sent it @jay-dee7 :)

from address-encoder.

Doh, sorry! Thanks for sorting it out between you.

from address-encoder.

I'm dumb, I should've sent the difference, not the whole amount, tip me back the corresponding amount @jay-dee7 when you read this.

from address-encoder.

⚡️ A tip worth 1.40000 ETH (319.74 USD @ $228.39/ETH) has been granted to @inspireme6 for this issue from @jay-dee7. ⚡️

Nice work @inspireme6! Your tip has automatically been deposited in the ETH address we have on file.

• $74282.79 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from address-encoder.

@inspireme6 i saw that lol, sent you the tip

from address-encoder.

Thanks @jay-dee7 @Arachnid

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 4.104 ETH (937.31 USD @ $228.39/ETH) attached to it as part of the ensdomains fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $75,220.10 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 6 days from now.
Please review their action plans below:

1) davidbanu has started work.

Would love to continue to work on this...
2) molecula451 has started work.

To study the Source Code, to test functionally. To improve the performance and to make better Software. I am ready to tackled down this issue
3) ariesjia has started work.

reduce size is my favorite, I want to join in
4) rjyun has started work.

Prioritize time and materials.
5) momodaka has started work.

first step: revmove duplicate code 435245 -> 434778
pr :#35
6) maksim-tolo has started work.

Would love to reduce the package size
7) amidmm has started work.

Let's see what is extra and what is not

Learn more on the Gitcoin Issue Details page.

from address-encoder.

$ npm run size

@ensdomains/[email protected] size /Users/xiaods/Documents/Code/address-encoder
browserify src/index.ts -p [tsify --noImplicitAny] | wc -c

440,005

add a patch to enhance the bundle.

PR/ #34

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 4.104 ETH (883.23 USD @ $215.21/ETH) has been submitted by:

1. @momodaka
2. @xiaods
3. @maksim-tolo

@Arachnid please take a look at the submitted work:

• PR by @maksim-tolo
• PR by @xiaods
• PR by @momodaka

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $75,193.49 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.

@momodaka @xiaods you guys realise that you won't be paid 4 eths for your submission? Please check the formula used for the payout calculation in the description. You can use npm run size or yarn size to compare size reduction and check your reward values

from address-encoder.

#37 reduces the size of the lib from 440007 to 275979 approximately. But it requires that the PR#2 of the cryptocodec gets merged first.

from address-encoder.

@inspireme6 Merged your PR #37 and updated the table!

from address-encoder.

@jay-dee7 thanks for your mention, I know the result.
eliminates someline duplicate code: the BNB config

from address-encoder.

Hi @Arachnid! Could you please look at #38 and ensdomains/crypto-addr-serialize#3?

from address-encoder.

meanwhile, I got nothing from this.... so thanks guys

from address-encoder.

@maksim-tolo Sorry for the delay; I will take a look shortly.

@x5engine I'm sorry, but you never submitted a PR that passed the build.

from address-encoder.

⚡️ A tip worth 0.67300 ETH (91.66 USD @ $136.19/ETH) has been granted to @inspireme6 for this issue from @Arachnid. ⚡️

Nice work @inspireme6! Your tip has automatically been deposited in the ETH address we have on file.

• $80590.94 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from address-encoder.

⚡️ A tip worth 0.69150 ETH (94.18 USD @ $136.19/ETH) has been granted to @maksim-tolo for this issue from @Arachnid. ⚡️

Nice work @maksim-tolo! Your tip has automatically been deposited in the ETH address we have on file.

• $80590.94 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from address-encoder.

Thank you all for your hard work! I think we've got as far as we reasonably can, so I'm paying out the remaining bounties and closing the issue.

from address-encoder.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

• Arachnid tipped 0.6915 ETH worth 94.18 USD to maksim-tolo.
• Arachnid tipped 0.6730 ETH worth 91.66 USD to inspireme6.
• jay-dee7 tipped 1.4000 ETH worth 190.67 USD to inspireme6.
• Arachnid tipped 1.4058 ETH worth 191.46 USD to jay-dee7.
• Arachnid tipped 2.4592 ETH worth 334.92 USD to inspireme6.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $80,145.71 more funded OSS Work available on the Gitcoin Issue Explorer

from address-encoder.