Giter Club home page Giter Club logo

Comments (5)

jvandijk avatar jvandijk commented on June 30, 2024

@syphernl do you see any issues if we do this?

from elasticsearch-formula.

syphernl avatar syphernl commented on June 30, 2024

@jvandijk If its the recommendation of Elastic I guess it'll be best we follow it. Matchminds and our team already does that and that approach seems to work just fine.

from elasticsearch-formula.

bsander avatar bsander commented on June 30, 2024

I recall discussing this with Frank a few weeks ago already. Our main reason for doing it like this was so that we could do a controlled upgrade of our environments, but we're on 8 everywhere now so I'm fine with making it the default 👍

from elasticsearch-formula.

jvandijk avatar jvandijk commented on June 30, 2024

@bsander @syphernl the current elasticsearch state installs the JRE package. You still have to add the elasticsearch.java state too. I'd suggest to make this implicit by requiring the java state within the formula itself instead of when consuming the formula. So far I see less then 10 required code changes in the whole Saltmaster repo after this addition, which even is compatible without changes.

from elasticsearch-formula.

eXistenZNL avatar eXistenZNL commented on June 30, 2024

This repository has not been maintained for years, closing this issue.

from elasticsearch-formula.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.