Comments (4)
Good point, first step would be to specify in inline documentation that everything is UTF-8.
Regarding supporting UTF-16, I don't see the point, really. I saw some stats that a huge majority of all Internet comms is UTF-8, so I think that's the thing to focus on with limited resources.
But a nice PR would be accepted, I suspect (@dantoml?)
from jay.
It's probably a relatively easy fix, but I'm not really interested in UTF-16 either, UTF-8 everywhere and all. But I was wondering what the point was of a raw data API if all you take is strings in a specific encoding anyway; might as well just take Strings instead, and not leave room for any error thanks to the type system? (if all the user has is Data/[UInt8], at least they know they have to think about what encoding it is in if the compiler tells you it needs a string).
from jay.
Ah I see, yeah that makes sense. I'd lean towards 1) documenting we only take UTF-8 and maybe 2) detect the first bytes while parsing and throw a specific error that says it's an incompatible encoding and that we need UTF-8. That should cover the majority of failing cases.
from jay.
Yeah, I'd go for initially documenting as UTF8 only, and throwing a better error. Then adding actual support later.
from jay.
Related Issues (20)
- Offer API to expose source maps of parsed JSON documents HOT 4
- Add unwrapping convenience functions HOT 1
- Add header documentation
- Performance comparisons? HOT 3
- CocoaPods HOT 2
- Swift 3?
- Add support for JSON comments HOT 1
- Also escape other whitespace control characters
- Also conform to RFC7159 HOT 4
- Incorrect String->Int map detection HOT 8
- Offer a String API HOT 7
- Cannot parse JSON with integer values bigger than Int.max HOT 1
- dataFromJson() Int 0,1 exchange Bool
- Incorrect parsing of Double values if the fraction part starts with zeroes
- Add JSON text visual formatting options
- Tagging a new version HOT 2
- Can't parse exponents that starts with zero
- Purpose of Jay struct HOT 2
- Investigate better way to detect/validate passed-in JSON object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jay.