[QZ#2] Errors about dsa-java HOT 5 CLOSED

From the attached picture, the error may come from L46.

Imaging when k=2, compare(k/3, k) would be compare(0, 2). Since the 0th element in keys is null, it would raise NullPointException.

from dsa-java.

Thanks for the feedback. In L46, I changed compare(k/3, k) to compare((k+1)/3, k), but I got new errors.

I also changed L38 to else if((k-1)%3==0 || k%3==0) { and changed L43 to else if((k+1)%3==0) { //if node is the left node

Also, is the problem/error only in swim() method? I can rewrite it if this is the case.

I have attached my errors and new code below:

from dsa-java.

Also, is there a way to do the benchmarking part of the assignment if these errors don't go away?

Thanks.

from dsa-java.

@ddalama the NPE is caused because you do not check the key index being 0, which returns null. Make sure it will not access the 0'th key that is null in your case.

from dsa-java.

@ddalama please do not post your code as an issue; if you need to please put the link to the code in your private repository. Closing this issue.

from dsa-java.