Comments (8)
Ok thanks ! I'm kind of into formal verification, so I tend to trust the specifications too much, I mean Brie does get a lot smellier each day in the fridge, and I live in France :) So, it fits.
from gildedrose-refactoring-kata.
Well spotted! Yes the code does some things that aren't fully documented. It's supposed to be legacy code after all 👍 You can basically assume that anything the code does is correct. It's in production, the Gilded Rose Inn is using it. If there is a conflict with the requirements, trust the code in preference.
Happy you had a go at the exercise!
Emily
from gildedrose-refactoring-kata.
Good to know about this hidden "feature" Emily. Is it possible that someone updates the requirements then?
I am also wondering if the different implementations (in several languages) share the exact same requirements. Unless I misunderstood something your reply suggests that this is not the case or someone would have to make sure all the implementations agree.
from gildedrose-refactoring-kata.
No, the requirements are perfect for the excercise exactly as they are.
from gildedrose-refactoring-kata.
I have problems understanding the exercise.
You say "if there is a conflict with the requirements, trust the code in preference."
and " the requirements are perfect for the exercise exactly as they are."
Obviously they are not "perfect" if code supersedes them so I have to understand what "perfect for the exercise" means
unless the point is for the requirements to be misleading on purpose. Is this the case? If they are not why keep inconsistency between code and the requirements?
from gildedrose-refactoring-kata.
Yes, this is an exercise that is supposed to be like real life. The requirements and code and any inconsistency between them is deliberate and part of the exercise.
from gildedrose-refactoring-kata.
OK then, thank you for the clarification. I'll take the "requirements" as a mere comment on the code then as they are supposed to be in real life ;-)
from gildedrose-refactoring-kata.
It was a surprising discovery, but I see how it makes sense from the requirements as written.
"Aged Brie" actually increases in Quality the older it gets
Once the sell by date has passed, Quality degrades twice as fast
These two specifications together mean Aged Brie gets 2 points once the sell by date has passed.
But hey, spoilers!
from gildedrose-refactoring-kata.
Related Issues (20)
- dotnet core test is not running on Windows plateform HOT 3
- Add Gilded Rose kata in JavaScript with Jest HOT 2
- Create `with_tests` branch HOT 2
- texttest quality values for Conjured Mana Cake incorrect HOT 5
- octave / matlab ? HOT 5
- cpp cpptexttest shows unidiomatic C++ HOT 2
- TextTestHarness vs Unit treatment of items HOT 2
- Java version seems to update tickets incorrectly HOT 3
- Error on stdout.gr for conjured items expected quality HOT 1
- Duplication HOT 2
- Link to Better Code Hub / BCH compliance badge broken in README.md HOT 1
- texttest conjured items HOT 2
- [cpp] tests not compiling for Catch2
- csharpcore Acceptance Tests stay blue (not executed) HOT 8
- texttest_fixture.py Doesn't follow requirements? HOT 1
- [PHP] Item class should not be final HOT 1
- Conjured items are under specified
- Rider doesn't detect unit tests in csharpcore exercise HOT 5
- Why are there 3 c# projects? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gildedrose-refactoring-kata.