Giter Club home page Giter Club logo

Comments (6)

emilsvennesson avatar emilsvennesson commented on June 4, 2024

Hi Johan! First of all, thanks a lot for letting me know about this beforehand. It's much appreciated.

Would you recommend me setting self.client (in cmore.py) to cmore-kodi or just for the search service request? I'm currently using cmore-android because I was unsure if anything else would have been an accepted client.

from kodi-cmore.

jsageryd avatar jsageryd commented on June 4, 2024

Most if not all services allow any value for the client param. We don't use this value to restrict usage (for that we use API keys or other means), but we often set this as a required param for the sake of our monitoring. If you should find a service that does not accept the value cmore-kodi, reach out and we'll try to get that sorted in one way or another. We'd much rather have each client (supported or not) use a correct identifier rather than scratching our heads about why a client that shouldn't be making requests oddly shows up on our graphs.

from kodi-cmore.

emilsvennesson avatar emilsvennesson commented on June 4, 2024

I've tried with cmore-kodi and it works fine for all services that's currently being used by this addon. :-)

I have some refactoring to do before I can switch to the new search API. I'll see if I can find some time to work on it this weekend.

from kodi-cmore.

emilsvennesson avatar emilsvennesson commented on June 4, 2024

@jsageryd Are you planning on replacing the search API used by the mobile apps? I just realized that the output from data.links.bbSearchAPI is quite different and would need some rework to adapt to.

from kodi-cmore.

jsageryd avatar jsageryd commented on June 4, 2024

The API linked to by data.links.bbSearchAPI will likely remain more or less the same for some time to come, save minor updates as we go along. It's hard to make any promises about how long "some time" is, but it won't be tomorrow.

from kodi-cmore.

emilsvennesson avatar emilsvennesson commented on June 4, 2024

This has now been done.

The end result is a bit of a Frankenstein hybrid between the mobile and web client, but I am pretty satisfied with how it turned out.

from kodi-cmore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.