Comments (1)
In particular:
- The 7 private mappings (
exp-string
,exp-string-left
, ...) essentially form an exploded map, which serves little purpose. They should be combined as one map:
(def ^{:private true} string-map
{:exp-string "..."
:exp-string-left "..."
...})
- All functions from
html-artist
tohtml-types
have big overlaps in their bodies. Just about all of them include such boiler-plate code as:
(some-> (select (child ...)))
first :content first trim
It is probably possible to factor out large parts of this code.
- It is problematic that
all-card-ids
is a blocking call. It would go nicely with the new-found asynchronous spirit of the parser to immediately return a channel that promises to have card IDs put onto it when the IO completes. This would make it much easier forall-cards
to return a channel immediately. - There is a very high degree of code duplication between
single-card
anddouble-card
. Clearly this can be factored out. -
In the same vein as list item (3.),card-by-id
should return a channel that it promises to eventually put the parsed card onto.
from majic.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from majic.