Add a User-Agent header to HTTP image loader about egui HOT 5 OPEN

Sounds good - PRs welcome!

from egui.

Are we going for a hard coded user agent or a configurable one? I could take a crack at it

from egui.

I've been looking through the code a bit and found out that egui-extras uses ehttp for the http ImageLoader which has hardcoded headers of just ("Accept", "*/*")

Do you want to simply pass the headers into ehttp::Request::get function, a builder pattern? (ehttp::Request::get("http://..").with_headers(..).build()) or perhaps something else?

from egui.

So a few hours of debugging and I found out that the URL I use to fetch images has unescaped qoutes ("\"https://..\"") which caused images to fail due to calling to_string() directly on serde_json::Value instead of something like as_str().unwrap_or("null").to_string() 🙃

from egui.

A hard-coded User-Agent: egui is a good start, but adding some way of changing it for EhttpLoader should be fairly easy.

from egui.