Giter Club home page Giter Club logo

Comments (5)

vilhalmer avatar vilhalmer commented on September 13, 2024 2

I don't know if there's a good way to do this without accidentally ruining some notifications' content. For example, if someone sends me a message on slack that contains a tag, I don't want that tag to be removed, since it was intended as the literal text of the tag.

from mako.

emersion avatar emersion commented on September 13, 2024

Hmm, yes, I've experienced this too. The spec allows us to advertise that we support markup, but doesn't allow clients to opt-out. :(

I think the fix you suggest is reasonable.

from mako.

progandy avatar progandy commented on September 13, 2024

Mako should probably filter unsupported html tags as well and only keep those that are defined in the freedesktop specification. I remember that was an problem in dunst.

Well, in the current version it simply tries pango markup and strips all tags if an error occurs. It seems that was greatly simplified some time ago.

from mako.

progandy avatar progandy commented on September 13, 2024

I guess in that case keep the tags for now and when a bug report is filed, add a criteria option to strip tags when receiving notifications from known bad clients.

from mako.

vilhalmer avatar vilhalmer commented on September 13, 2024

Hmmm, perhaps the markup criteria should be modified to only affect the received content, but always allow parsing of the markup specified in the user's format? If the user really doesn't want markup at all, they should remove the tags from the format themselves anyway.

from mako.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.