Comments (5)
I don't know if there's a good way to do this without accidentally ruining some notifications' content. For example, if someone sends me a message on slack that contains a tag, I don't want that tag to be removed, since it was intended as the literal text of the tag.
from mako.
Hmm, yes, I've experienced this too. The spec allows us to advertise that we support markup, but doesn't allow clients to opt-out. :(
I think the fix you suggest is reasonable.
from mako.
Mako should probably filter unsupported html tags as well and only keep those that are defined in the freedesktop specification. I remember that was an problem in dunst.
Well, in the current version it simply tries pango markup and strips all tags if an error occurs. It seems that was greatly simplified some time ago.
from mako.
I guess in that case keep the tags for now and when a bug report is filed, add a criteria option to strip tags when receiving notifications from known bad clients.
from mako.
Hmmm, perhaps the markup
criteria should be modified to only affect the received content, but always allow parsing of the markup specified in the user's format
? If the user really doesn't want markup at all, they should remove the tags from the format themselves anyway.
from mako.
Related Issues (20)
- makoctl history returns "type" : "aa{sv}" .... HOT 4
- Failed to connect to user bus: No such file or directory (2) HOT 1
- Improve README's Running section HOT 3
- Same ID on notification renders a new notification HOT 2
- Invoke default action also for restored notifications HOT 2
- No notification display after monitor hotplug
- pango markup doesn't work in title
- [Feature Request] Hover to dismiss
- menu opened from mako aren't killeable
- synchronous with notifi-send HOT 1
- Feature Request: Implement Different Border-Radius Options for Individual Corners HOT 1
- Mako cannot play sound if started automatically HOT 6
- JQ alternatives HOT 3
- ERROR: Neither source directory 'build' nor build directory None contain a build file meson.build HOT 1
- Implement an include option
- [Feature Request] Make "makoctl restore" also restore actions HOT 1
- Make `border-size` directional HOT 1
- Can't play a sound when a notification is opened HOT 1
- Support for pausing notifications while in fullscreen
- do-not-disturb/dnd/invisible mode is still disturbing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mako.