Giter Club home page Giter Club logo

Comments (6)

jasonmit avatar jasonmit commented on May 16, 2024

@ericf I kind of like having them separate, otherwise the consumer will need to be cognizant of keeping the default locale at the tail of the locales array.

This is currently how its used in ember-intl.

// pseudo-code but it's pretty similar
getMessage: function (path) {
  var locales = Ember.makeArray(this.locales); // in case the user just set a string
  locales.push(this.defaultLocale); // in the actual implementation I don't push if locales contains the defaultLocale
  for(var i=0;i<locales.length;i++) {
    var locale = this.getLocaleObject(locales[i]);
    var msg = locale.get(key);
    if (typeof msg !== 'undefined') { return msg; }
  }
}

from ember-intl.

ericf avatar ericf commented on May 16, 2024

This the way locales is suppose to work as a fallback anyways, so I think it fits. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation

from ember-intl.

jasonmit avatar jasonmit commented on May 16, 2024

Ah, that makes sense. I'll remove it. Do you want me to update the other libs while I'm at it?

from ember-intl.

ericf avatar ericf commented on May 16, 2024

Ah, that makes sense. I'll remove it. Do you want me to update the other libs while I'm at it?

Let's discuss it first. That's why I cc'd @caridy

from ember-intl.

jasonmit avatar jasonmit commented on May 16, 2024

The result of the chat offline was to remove references to defaultLocale and then remove it from the code base when we remove it from all the other integration libs.

from ember-intl.

jasonmit avatar jasonmit commented on May 16, 2024

#67 supersedes this

from ember-intl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.