Type issues from Registry about ember-intl HOT 6 CLOSED

@ijlee2 haven't had a chance to even respond, let alone create the issue until now! Thanks for the head's up!

from ember-intl.

@jamescdavis Can you lend support? I'm not sure where to start.

When #1719 had been merged, ember-intl had relied on version 0.9.x of Glint. I wonder if, with the latest 1.0.x, the types may need to be reviewed again and possibly redefined.

I'll see if I can help update @glint/* packages in #1766.

from ember-intl.

Will close the issue, as I was able to extend the template registry from ember-intl with @glint/[email protected] in a "hello-world" app.

Note, the types for ember-intl are currently checked against @glint/[email protected]. We'll need to check against the latest 1.x soon.

from ember-intl.

@ijlee2 - sorry to bug you, but I am still facing the above error while using ember-intl 6.1.0

I've already added:

import type EmberIntlRegistry from 'ember-intl/template-registry';

declare module '@glint/environment-ember-loose/registry' {
  export default interface Registry extends EmberIntlRegistry {
...
  }
}

Potentially related to my issue, I am additionally seeing duplicate service declarations, on top of the other errors in this issue.

jluna@DESKTOP-CDO6AK3:~/fantasy-epl$ tsc --noEmit
node_modules/ember-intl/addon/services/intl.d.ts:136:5 - error TS2717: Subsequent property declarations must have the same type.  Property 'intl' must be of type 'IntlService', but here has type 'IntlService'.

136     intl: IntlService;
        ~~~~

  node_modules/ember-intl/services/intl.d.ts:136:5
    136     intl: IntlService;
            ~~~~
    'intl' was also declared here.

from ember-intl.

@SemaLuna No worries. Due to EmberFest, I'm unable to look at issues this week.

Given the error message, Subsequent property declarations must have the same type., I found a possibly related issue on StackOverflow.

A possible solution is to set compilerOptions.skipLibCheck to true in tsconfig.json. However, I think we should fix the type error if possible. In a project of mine, I can reproduce the type error that you showed by removing skipLibCheck.

Can you open a new issue to describe the error? If you can help with the bug fix, please feel free to create a pull request, too. Thanks.

from ember-intl.

@SemaLuna We have a dedicated issue now. #1787

from ember-intl.