Giter Club home page Giter Club logo

Comments (4)

rwjblue avatar rwjblue commented on June 20, 2024

Adding a dependency on ember-asset-loader does not inherently cause an asset manifest to be created. You need to either include ember-engines (which does create an assert manifest), or configure something in your application to use ManifestGenerator.extend itself.

from ember-asset-loader.

rwjblue avatar rwjblue commented on June 20, 2024

I can't actually tell what you are trying to do here. Are you trying to emit two asset manifests?

from ember-asset-loader.

rwjblue avatar rwjblue commented on June 20, 2024

There definitely is a bug here: lib/manifest-generator.js uses the second argument to contentFor to determine the modulePrefix which will not match the expected module prefix when app/config/asset-manifest.js module is evaluated.

var metaName = config.modulePrefix + '/config/asset-manifest';

Should be gathering the modulePrefix from the findHost result, not the second argument. That would resolve this specific error.

from ember-asset-loader.

evanfarina avatar evanfarina commented on June 20, 2024

Rob and I spoke offline. I have an external addon which lazily-loads a static asset on behalf of consuming host apps. We were using ember-asset-loader's loadAsset method to achieve this. The issue brought up in this ticket exists if the host app also depends on ember-engines, which itself depends on, and extends from, ember-asset-loader and therefore produces its own manifest.

In short, a host app with an engine which also brings in an external addon with ember-asset-loader will result in a fatal error.

We have decided that, for the time being, we will do our own simple script loading in our addon and remove ember-asset-loader as a dependency. Potentially in the near future we can modify ember-asset-loader to allow for loading of an asset without a manifest.

from ember-asset-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.