Giter Club home page Giter Club logo

Comments (7)

stefanpenner avatar stefanpenner commented on May 22, 2024

sounds great!

from ember-cli.

joefiorini avatar joefiorini commented on May 22, 2024

Got my answer, thanks. :)

from ember-cli.

joliss avatar joliss commented on May 22, 2024

So the plan is, drop in the EAK stuff, then refactor to Broccoli? Sounds good to me. @joefiorini if you want to help, try to avoid having stuff sitting in your local clone for too long - just send piecemeal PRs -, or we'll have merge conflict.

from ember-cli.

joefiorini avatar joefiorini commented on May 22, 2024

@joliss I was planning to separate the builder so we could have work going on the broccoli implementation throughout. To test it we can pass a flag, like: ember build --builder broccoli. This should minimize the risk of conflicts. As soon as I have it successfully building I'll open a PR so we can start communicating about it. Sound good?

from ember-cli.

joefiorini avatar joefiorini commented on May 22, 2024

Got some initial work going in my fork. So far I have ember build development and ember build production working (with minimal testing). I've started on ember server. What do you guys think of the direction I'm taking? At what point should I open a PR to get it merged in? @joliss @stefanpenner

from ember-cli.

joliss avatar joliss commented on May 22, 2024

Skimming the commits, I like the general direction. Let's not spend too much time on grunt, it's going away for sure.
PR: As quickly as possible, so we avoid conflicts. Partial progress is good. Just be sure to rewrite your history into something meaningful (git rebase -i), I'd like to avoid random "WIP" commits scattered about.

from ember-cli.

joefiorini avatar joefiorini commented on May 22, 2024

@joliss I usually don't like doing WIP commits, only pushed that one because I had a hard stop and wanted to share the direction I'm heading. Don't worry, it'll be gone soon.

As for grunt, the primary goal is to pull it in to get some structure in place and get a head-start on making it more configurable. That stuff should be the same regardless of the build system, right?

Do you have work done already on integrating this with broccoli?

from ember-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.