Highlighting for exported functions. about typescript.el HOT 5 CLOSED

Thanks for the bug-report.

I'm going to assume this was an omission. I'll label it a bug, and see if we can't get it fixed.

If you could show us your changes, maybe we could review them together and see if we find them sufficient. If so, you could always submit them as a PR.

from typescript.el.

I've added a new matcher for declare or export modifiers:

(defconst typescript--module-declaration-re
  "^\\s-*\\(?:declare\\|\\(?:export\\(?:\\s-+default\\)?\\)\\)?"
  "Regexp matching ambient declaration modifier or export declaration")

and then added that to typescript--function-heading-1-re as follows:

(defconst typescript--function-heading-1-re
  (concat
   typescript--module-declaration-re
   "\\s-*function\\s-+\\(" typescript--name-re "\\)")
  "Regexp matching the start of a typescript function header.
Match group 1 is the name of the function.")

from typescript.el.

Sorry about the delay. I've had quite a few other issues I've been trying to close before starting yet another one. :)

Comparing to what is already done in js-mode, you have the same exact problem there, so there is no code we can "borrow" for a more proven approach.

js2-mode seems structured in a completely different way, and while it has this already solved, I see no obvious way to re-use their solution.

As such, and from what I can tell, that looks perfectly OK. I have no objections to it.

Feel free to send it in as a PR, and other people more versed in font-locking code can help improve it if they see the need.

from typescript.el.

Great, I'll put a PR in over the next few days. Thanks!

from typescript.el.

Fixed in #54. Closing.

from typescript.el.