Comments (4)
Yes, that's definitely fair. I would love to be able to give something back, since working with this in concert with tide
is a joy.
Can you point me maybe a little in the direction of where to look?
[edit]
nevermind, I see how it is done. I'll start reading up on font-lock and how highlighting is accomplished in general in Emacs modes. Thank you for your comments to far. I'll close for now, and when I have something I'll make a PR.
from typescript.el.
I don't think typescript-mode
can solve this in general. If you do import { x } from "foo"
, is x
a type or a variable? typescript-mode
cannot know because it does not have the machinery necessary to load "foo"
and check.
On the other hand, it should be possible to have tide
(which can figure out what x
is in my example above) augment the fontification provided by typescript-mode
. Looking quickly at its code I do not see any such case of augmentation now, but in theory, it should be possible.
from typescript.el.
hmm yes, I can see that makes sense for tokens that need to be inferred. How about though:
- the type assertions in function declaration?
- something ending with parentheses is a function?
from typescript.el.
I'm sure there are room for improvements. Feel free to issue patches for it.
from typescript.el.
Related Issues (20)
- typescript-beginning-of-defun misses ES2015 forms HOT 2
- can't seem to indent props in JSX expression HOT 1
- Consider migrating CI to something not Travis HOT 5
- Symbol’s value as variable is void: compilation-error-regexp-alist-alist HOT 4
- Indentation hangs in `typescript--backward-to-parameter-list` when previous function has unbalanced parens
- typescript-mode hangs if I enter a newline after a dot character.
- File mode specification error: (void-function -compose) HOT 3
- typescript new keyword 'override' highlight HOT 2
- M-j in /** foo */ comment blocks is broken. Reasonbly easy to fix HOT 3
- Bump Version Tag HOT 8
- const, let formatting with multiple lines HOT 1
- Missing debugger keyword HOT 1
- Freeze on indenting dot after comma HOT 1
- `typescript-mode` is failing to download HOT 4
- Incorrect highlighting of keywords on latest commit HOT 5
- Adding mechanisms in place not to collide with in-tree typescript-mode HOT 7
- typescript 4.9 - satisfies operator HOT 1
- No option to achieve desired formatting HOT 1
- typescript--backward-to-parameter-list can cause multi-second delays in large files HOT 4
- Diagnostics don't show until file is changed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.el.