Giter Club home page Giter Club logo

Comments (4)

bklaase avatar bklaase commented on July 17, 2024 1

Yes, that's definitely fair. I would love to be able to give something back, since working with this in concert with tide is a joy.
Can you point me maybe a little in the direction of where to look?

[edit]
nevermind, I see how it is done. I'll start reading up on font-lock and how highlighting is accomplished in general in Emacs modes. Thank you for your comments to far. I'll close for now, and when I have something I'll make a PR.

from typescript.el.

lddubeau avatar lddubeau commented on July 17, 2024

I don't think typescript-mode can solve this in general. If you do import { x } from "foo", is x a type or a variable? typescript-mode cannot know because it does not have the machinery necessary to load "foo" and check.

On the other hand, it should be possible to have tide (which can figure out what x is in my example above) augment the fontification provided by typescript-mode. Looking quickly at its code I do not see any such case of augmentation now, but in theory, it should be possible.

from typescript.el.

bklaase avatar bklaase commented on July 17, 2024

hmm yes, I can see that makes sense for tokens that need to be inferred. How about though:

  • the type assertions in function declaration?
  • something ending with parentheses is a function?

from typescript.el.

josteink avatar josteink commented on July 17, 2024

I'm sure there are room for improvements. Feel free to issue patches for it.

from typescript.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.