Giter Club home page Giter Club logo

Comments (5)

lddubeau avatar lddubeau commented on July 17, 2024 1

@jcs090218 Yeah, we've gotten into the habit of saying "PRs welcome".

@josteink Any objection to the systematic use of the "help-wanted" label for those cases where we'd say "PR welcome"? I think right now it would mean turning it on for all (or almost all) issue reports.

from typescript.el.

lddubeau avatar lddubeau commented on July 17, 2024

We welcome PRs to fix this.

from typescript.el.

jcs090218 avatar jcs090218 commented on July 17, 2024

I would like to help, but I'm assure I'm bad at regexp. My solution wouldn't be the best, maybe it would be good to have help-wanted tag on this issue?

from typescript.el.

josteink avatar josteink commented on July 17, 2024

I was about to make a comment that this label is implicitly applicable to any unsold an open issue which we have in this repo.

That’s said I see no problem with being a little more explicit about it. Feel free to tag any and all issues you like 👍

from typescript.el.

Fuco1 avatar Fuco1 commented on July 17, 2024

This is a very simple fix. Since the functions are fontified after keywords (which are level 2) all that is needed is to allow font-lock to overwrite the existing fontification. I'll make a PR in a couple minutes.

from typescript.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.