normal-state interacts poorly with eval-last-sexp about evil HOT 5 CLOSED

Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):

Make `evil-last-sexp' work with closing parenthesis under point (fixed #17)

This is done by advicing preceeding-sexp' and pp-last-sexp'.

from evil.

Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):

Make `evil-last-sexp' work with closing parenthesis under point (fixed #17)

This is done by advicing preceeding-sexp' and pp-last-sexp'.

from evil.

Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):

Make `evil-last-sexp' work with closing parenthesis under point (fixed #17)

This is done by advicing preceeding-sexp' and pp-last-sexp'.

from evil.

Original comment by Anonymous:

Thinks. I had to change them slightly so that they continued to work in insert-mode (I'm not sure if that was the intent, but I like it like that). But I have discovered one edge case (which also affects my solution): save-excursion means you can't move the cursor when doing eval-last-sexp in normal-mode. My current fix is to advise the "find the last sexp" functions instead:

(defadvice preceding-sexp (around evil)
  "In normal-state, last sexp ends at point."
  (if (evil-normal-state-p)
      (save-excursion
	(unless (or (eobp) (eolp)) (forward-char))
	ad-do-it)
    ad-do-it))

(defadvice pp-last-sexp (around evil)
  "In normal-state, last sexp ends at point."
  (if (evil-normal-state-p)
      (save-excursion
	(unless (or (eobp) (eolp)) (forward-char))
	ad-do-it)
    ad-do-it))

(I'm not sure why both of these functions exist.) I haven't noticed any problems with this. It's possible that if someone uses these functions noninteractively, things would break; in that case, I can't think of a better solution than "reimplement [pp-]eval-last-sexp". But in core, they don't seem to be used anywhere bad: just a helper function of eval-last-sexp, and pp-eval-last-sexp and pp-macroexpand-last-sexp, respectively.

from evil.

Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):

You may try the following code which advices some function when evil
is activated. If you use at least 35ff006 those modifications should
be activated if and only if evil is active. If those modifications
work they could go into evil's code.

;;; eval-last-sexp
(defadvice eval-last-sexp (around evil)
  "Last sexp ends at point."
  (when (evil-normal-state-p)
    (save-excursion
      (unless (or (eobp) (eolp)) (forward-char))
      ad-do-it)))

;;; pp-eval-last-sexp
(defadvice pp-eval-last-sexp (around evil)
  "Last sexp ends at point."
  (when (evil-normal-state-p)
    (save-excursion
      (unless (or (eobp) (eolp)) (forward-char))
      ad-do-it)))

from evil.