Giter Club home page Giter Club logo

Comments (5)

vitorpldev avatar vitorpldev commented on July 28, 2024

I've been trying to find out the cause of this for some time, from the tests I've done, apparently the decorates I've been using on different controllers are replacing each other.

code

For some reason in the controllers function when I say to group the urlController after the userController, the decorate that the userController uses (userService) is being deleted and replaced by the decorate of the urlController (urlService).
When I call the /user/create route, the result is that services.user.create is not a defined function

from elysia.

bogeychan avatar bogeychan commented on July 28, 2024

@vitorpldev, can you please post code snippets in text form? checkout Creating and highlighting code blocks

from elysia.

vitorpldev avatar vitorpldev commented on July 28, 2024

Okay, the code I gave as an example is this:

import Elysia, { t } from "elysia";

const user_decorator = (application: Elysia) => {
  return application.decorate({
    services: {
      find: (name: string) => `The name of user is ${name}`,
    },
  });
};

const url_decorator = (application: Elysia) => {
  return application.decorate({
    services: {
      find: (url: string) => `The url is ${url}`,
    },
  });
};

const user_controller = (application: Elysia) => {
  return application.use(user_decorator).get(
    "/",
    ({ query, services }) => {
      return new Response(services.find(query.value), { status: 200 });
    },
    {
      query: t.Object({ value: t.String() }),
    }
  );
};

const url_controller = (application: Elysia) => {
  return application.use(url_decorator).get(
    "/",
    ({ query, services }) => {
      return new Response(services.find(query.value), { status: 200 });
    },
    {
      query: t.Object({ value: t.String() }),
    }
  );
};

const controller = (application: Elysia) => {
  return application
    .group("/user", (user) => {
      return user.use(user_controller);
    })
    .group("/url", (url) => {
      return url.use(url_controller);
    });
};

const app = new Elysia().use(controller);

app.listen({ hostname: "localhost", port: 3030 }, (server) => {
  console.log(`Server is running at ${server.url}`);
});

If in this code I make a request for GET
for http://localhost:3030/user/ passing the value "Elysia" in the query, the expected would be "The name of user is Elysia", but the result is "The url is Elysia".
This is because the way in controllers I am grouping the url_controller after the user_controller, the decorate of the url_controller is replacing the decorate of the user_controller

from elysia.

nxht avatar nxht commented on July 28, 2024

@vitorpldev
Both user_decorator and url_decorator is decorating same services, I think it's expected to get overridden.

You can either

  • Use different name to decorate instead of services like user_services and url_services
  • If you want to keep it as it is, you might consider using derive instead as you can define the scopes

from elysia.

vitorpldev avatar vitorpldev commented on July 28, 2024

Perfect, thank you my friend.

from elysia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.