Giter Club home page Giter Club logo

Comments (6)

fishzle avatar fishzle commented on May 29, 2024 1

If the integrity check fails, it could clean itself up.
Then a user would just run it again, and there wouldn't be another switch to maintain.

from tinynvidiaupdatechecker.

TotalLag avatar TotalLag commented on May 29, 2024

Yes, if it behaved this way then I agree, no extra switch needed :)

from tinynvidiaupdatechecker.

ElPumpo avatar ElPumpo commented on May 29, 2024

Sorry for the extreme delay. Isn't this what --confirm-dl. I'll look into the %temp% directory used causing issues.

from tinynvidiaupdatechecker.

ElPumpo avatar ElPumpo commented on May 29, 2024

This is a weird issue since it checks if an existing file exists, if it does not match the size of the supposed driver file then it is deleted before downloading.
But I am going to change the code a bit so when it downloads, it will save as a .partial file format. This makes it easier to see a failed download, and if TNUC sees it then it is to be deleted. Most browsers do similar stuff.

from tinynvidiaupdatechecker.

ElPumpo avatar ElPumpo commented on May 29, 2024

3640d2e Improved the situation a bit but the code definitly needs a lot of love & rewriting. Many exceptions are not properly handled.

from tinynvidiaupdatechecker.

ElPumpo avatar ElPumpo commented on May 29, 2024

I've tested to replicate the issue you're having. After installation the file is cleaned up which is up for a debate if a dialog should pop up asking if you want to keep the driver files.

Worst case if it %temp%/ doesn't get cleaned up after installation then still at least the code now checks the driver file size, which shouldn't be incomplete anyways since it nows gets downloaded as a .part file until it's completed where it then gets renamed back and there's a file size check, too.

(The dialog file downloader does not have this new code.. yet)

I'll be closing this issue if it happens to you again then you'll have to reopen it.

image

This is what happens when there's existing files and minimal install is used, and quiet mode is on.

from tinynvidiaupdatechecker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.