Unhandled Exception when downloading PDF about tinynvidiaupdatechecker HOT 14 CLOSED

pdfURL is still unusable, but it no longer asks if you want to see the release notes, so at least it won't crash.

from tinynvidiaupdatechecker.

53ce9df#diff-5459f3b43e8938ca10b327da43540fa5R755

from tinynvidiaupdatechecker.

Aight, first off thanks for using TinyNvidiaUpdateChecker! Try running it with the --debug parameter and check if pdfURL was set to something, and do you even have a pdf reader installed on your computer? That might be the cause of the issue..

from tinynvidiaupdatechecker.

After some debugging it has been confirmed that the cause of InvalidOperationException when trying to open the pdf file is because there is no application set to open .pdf files.

from tinynvidiaupdatechecker.

I do have a PDF reader installed (SumatraPDF 64-bit), and it is set as the default PDF reader in Windows. I thought for a second that Windows 10 had (in)conveniently forgotten about it, but it is installed and does work. pdfURL wasn't set, though. Even tried switching to Sumatra 32-bit and Microsoft Edge. The problem isn't lack of a PDF viewer, it's not getting the pdfURL.

Thanks for making this program, by the way. It's nice not having to use GeForce Experience or the website.

from tinynvidiaupdatechecker.

And are you 100% sure that you are running v1.4.1 and not v1.4.0? You can check this by using the --version parameter. If pdfURL equals null the application will not ask you if you want to see the release notes - the check was added in v1.4.1.

from tinynvidiaupdatechecker.

Screenshot for you. Definitely v1.4.1. Definitely still showing me if I want to see release notes. I know I used --force-dl, but it was doing the same thing before I updated the drivers. Even if I don't use --force-dl, pdfURL isn't set.

from tinynvidiaupdatechecker.

-removed link- try that build if the issue is fixed

from tinynvidiaupdatechecker.

The cause for pdfURL to be null is because nvidia removed the release notes.

from tinynvidiaupdatechecker.

Background: gpuURL was set to space, which is not null. The check before displaying the pdf question checks if it is null. I added .Trim() methods which removes misc chars from all the strings fetched from the NVIDIA website.

from tinynvidiaupdatechecker.

The cause for pdfURL to be null is because nvidia removed the release notes.

Not certain if this is either a miscommunication or a misunderstanding, but the release notes are still available, for example, here's the latest one. Your method of retrieving the release notes might need to be changed, but the release notes are still there.

from tinynvidiaupdatechecker.

Not certain if this is either a miscommunication or a misunderstanding, but the release notes are still available, for example, here's the latest one. Your method of retrieving the release notes might need to be changed, but the release notes are still there.

No my friend, the thing is that there is no release notes on the website itself. You can try this yourself by navigating to processURL and select Additional Information. There is no release notes available. This is not the first time NVIDIA has deleted release notes from their drivers from the download page.

from tinynvidiaupdatechecker.

It's not linked on the Nvidia page, but it is linked on the GeForce page. From what I can tell, a consistent way to download them would be something along the lines of:

For desktop:
pdfURL = "http://us.download.nvidia.com/Windows/" + onlineGPUDriverVersion + "/" + onlineGPUDriverVersion + "-win10-win8-win7-desktop-release-notes.pdf";

For mobile:
pdfURL = "http://us.download.nvidia.com/Windows/" + onlineGPUDriverVersion + "/" + onlineGPUDriverVersion + "-win10-win8-win7-notebook-release-notes.pdf;"

Then you can get rid of lines 592-594, and insert new logic while you're already identifying desktop or mobile, inserting defining pdfURL between lines 540-541 and between 543-544. The only possible downside I can imagine is if they put up release notes in multiple languages. (As far as I can tell, they don't.)

EDIT: Just realized that onlineGPUDriverVersion won't work as-is that way. The URL would be missing two periods, e.g., "375.70" vs. "37570".

Maybe this?

onlineGPUString = onlineGPUDriverVersion.ToString();
onlineGPUString = onlineGPUString.Insert(onlineGPUString.Length() - 2, ".");

then
pdfURL = "http://us.download.nvidia.com/Windows/" + onlineGPUString + "/" + onlineGPUString + "-win10-win8-win7-desktop-release-notes.pdf";
and
pdfURL = "http://us.download.nvidia.com/Windows/" + onlineGPUString + "/" + onlineGPUString + "-win10-win8-win7-notebook-release-notes.pdf";

from tinynvidiaupdatechecker.

To respond to your updated comment, I already changed all the fields to strings with proper stuff.

from tinynvidiaupdatechecker.