Giter Club home page Giter Club logo

Comments (5)

robertmain avatar robertmain commented on August 15, 2024

not really any of my business, but I'd suggest setting a default value on $options to be something other than zero....preferably JSON_UNESCAPED_UNICODE or some such

from api-response.

maximebeaudoin avatar maximebeaudoin commented on August 15, 2024

@robertmain Currently, the default value from Illuminate\Contracts\Routing\ResponseFactory is 0. You can see the file https://github.com/laravel/framework/blob/5.5/src/Illuminate/Contracts/Routing/ResponseFactory.php#L37 so it's make sense to keep it that way.

@dickwu I think this is a really good idea. You can create a PR for that if you want.

from api-response.

robertmain avatar robertmain commented on August 15, 2024

@maximebeaudoin is that value available as a constant? I'm thinking it might make more semantic sense. Either way, just a thought :)

from api-response.

dickwu avatar dickwu commented on August 15, 2024

@robertmain you can see this with more info http://php.net/manual/en/function.json-encode.php

from api-response.

dickwu avatar dickwu commented on August 15, 2024

@maximebeaudoin I have already submitted it directly

from api-response.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.