Giter Club home page Giter Club logo

Comments (8)

shuuji3 avatar shuuji3 commented on September 21, 2024 5

@piotrski Ah, sorry, I submitted a PR to Homebrew/homebrew-cask just before reading the above comment: Homebrew/homebrew-cask#139778. 🙏🏻

I changed it to a draft PR now. Please let me know if you think you are ready to submit it. I can update the PR so that they can review and merge it.

from elk-native.

piotrski avatar piotrski commented on September 21, 2024 2

It would be nice, but I would wait a bit until we polish a few major issues.

from elk-native.

JonasKruckenberg avatar JonasKruckenberg commented on September 21, 2024 2

we can definitely have a workflow for submitting PRs, we need a similar thing to submit latest release links to the elk docs too though that's a different issue.

from elk-native.

piotrski avatar piotrski commented on September 21, 2024

@shuuji3 do we have to update it in the homebrew repo every time we release a new version?

from elk-native.

sxzz avatar sxzz commented on September 21, 2024

@piotrski I think so. There are already 133k PR in the homebrew-cask repo. We have to make a PR when every release.

Maybe we can have a release bot for homebrew in the future.

from elk-native.

shuuji3 avatar shuuji3 commented on September 21, 2024

Yes, I think so too. But unless the current structure such as the package name convention and the release URL is changed, I think the only you need to change would be the version number and package hash: https://github.com/shuuji3/homebrew-cask/blob/add-elk/Casks/elk.rb#L4-L6

Also, Homebrew is providing the built-in subcommand called brew bump-cask-pr to upgrade and create a new PR with minimal effort. Maybe you can also use it in the automation.

from elk-native.

ShadowJonathan avatar ShadowJonathan commented on September 21, 2024

If i understand correctly, this can now be installed with brew install --cask elk, right?

from elk-native.

shuuji3 avatar shuuji3 commented on September 21, 2024

@ShadowJonathan Yes, you're correct. I also confirmed that version v0.4.0 can be installed now with that command.

@JonasKruckenberg @piotrski @sxzz Sorry, I was being waited for your approval but the original PR had been merged now. Do you think it's ok? Honestly, I think the current version of Elk native is enough stable and working well so we keep the published brew cask to provide users a way to test easily. You can also update the install documentation for Homebrew at any time you'd like maybe after additional iterations. What do you think?

from elk-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.