Giter Club home page Giter Club logo

Comments (6)

Ziinc avatar Ziinc commented on May 14, 2024

You will need to add in request options for HTTPoison through the RequestOptions request middleware . The format needs to match the option format in the HTTPoison docs

https://hexdocs.pm/crawly/Crawly.Middlewares.RequestOptions.html

https://hexdocs.pm/httpoison/HTTPoison.Request.html#content

from crawly.

Ziinc avatar Ziinc commented on May 14, 2024

@Unumus did you search through the docs before opening this issue? If you did but didnt' find the RequestOptions middleware, we might need to update the docs for it

from crawly.

oltarasenko avatar oltarasenko commented on May 14, 2024

@Ziinc I was also thinking about making an explicit example somewhere in docs...

from crawly.

 avatar commented on May 14, 2024

@Ziinc, I searched. But not found. I think it will be helpful to mention here: https://hexdocs.pm/crawly/configuration.html#proxy-binary the middleware.requests to complete proxy configuration.

from crawly.

Ziinc avatar Ziinc commented on May 14, 2024

@Unumus ah I see, the docs got out of sync, the proxy setting on :config is from an older version that is a breaking change. We'll need to update that.

@oltarasenko I think perhaps a few common use case examples can be shown in the middleware module doc? Besides proxy, what others would be good?

  • remove proxy setting from config.

from crawly.

Ziinc avatar Ziinc commented on May 14, 2024

@oltarasenko You might need to do a patch release to update hexdocs

from crawly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.