[Bug] Wrong Transaction Statement committed succesfully about comp4111_project HOT 4 CLOSED

BTW the timezone is actually wrong. It presents 6:35 when the time is either 2:35 or 14:35. However, it doesn't really affect the 2-minutes time limit thing according to specification.

So I am leaving it here just as a warning.

from comp4111_project.

Would like to argue that validation of putting transactional statements are not documented in the project spec as well as the detailed test cases

In a perfect world, an invalid transaction would be catched in the put action and rejected. We are fully aware of this. However it is not mentioned specs, that's why it make sense to catch them when it is time to commit and rollback the transaction (which is documented and we forgot to implement and is now a standalone issue #13)

My argument here is if the where the validation of statement should be handled is unclear in the spec. Since the requirement of catching invalid statement is not present in the spec, and the rollback action is detailed in the spec if any statement error is encountered, we did not implement invalid statement handling (for non existing book id) in put action.

And since the failure of rolling back a transaction is already documented in #13, I do not agree this is a valid bug.

Again I will let @comp4111ta for the decision.

Cheers.

from comp4111_project.

Sorry if something is a bit unclear. Indeed, the specification is unclear and it's perfectly fine in my opinion to do the checking in either the put action or commit action.

The problem here is that the validation itself is wrong. It will always return SC_OK for both put action and commit action. Depending on the implementation, one would expect a 400 bad request in one of the two actions, in which the current program fails to achieve.

And since the validation always return true, rollback behavior in #13 seems to be inaccessible, if not actually implemented incorrectly. I think we can let @comp4111ta to decide it as either a single issue or two different issues.

Thanks!

from comp4111_project.

TA Verified: This is not considered as a bug.

from comp4111_project.