Comments (3)
Thanks for the report.
Just wanted to leave the note that this (and your other issue) are on my TODO list but I'll need to carve out a couple of hours of focus time to page Raft context back in; this will probably happen after my upcoming vacation.
from raft.
I looked a bit into it, and you may be right! Haven't looked deep into this code for a long while, so it took me time to load state back into my brain, so to speak. I created #15 as an attempted fix - just in part 3 for now. Let me know how it looks.
FWIW I think the worst that can happen here is temporary confusion - I don't think any data will be permanently lost. The leader should have the up-to-date index log, after all.
That said, it is an easily fixable race, so why not.
from raft.
Thanks for your reply, the fix looks good to me.
from raft.
Related Issues (10)
- Why we do not check errors in AE responses? HOT 1
- Why do need to use lock in RPC calls? HOT 2
- becomeFollower may update the term from a higher one back to a low one HOT 1
- Check before updating nextIndex and matchIndex HOT 3
- Eternal leader HOT 2
- Does the `startElection()` method has a potential race condition in it? HOT 1
- Is `intMin(args.LeaderCommit, len(cm.log)-1)` needed? HOT 1
- What if this heartbeat with empty entry ? HOT 2
- TestCrashAfterSubmit HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raft.