Giter Club home page Giter Club logo

Comments (6)

elfalem avatar elfalem commented on August 23, 2024

Hello!
Can you provide more details about your environment.

  • What hardware (model, CPU, RAM), operating system, and browser are you seeing the issue on?
  • To what level are you zoomed in when you start seeing the issue?
  • Is the issue limited to curves with animations and/or dashes only or does it happen with non-animated curves with solid lines?
  • Are you able to quantify the CPU usage (it jumps from __% usage to __% usage)?

from leaflet.curve.

spmsupun avatar spmsupun commented on August 23, 2024

@elfalem Close this

from leaflet.curve.

jayli3n avatar jayli3n commented on August 23, 2024

@elfalem Close this

This is still an issue I wonder why it was closed, if you zoom in to an animated line close enough, it lags a whole lot :(
Can test it with the demo project: http://elfalem.github.io/Leaflet.curve/

from leaflet.curve.

jayli3n avatar jayli3n commented on August 23, 2024

After some more testing, the lag ONLY occurs to dashed lines, whether animation is turned on or off does not affect CPU usage.
It seems to be related to the way the dashed lines are generated.

from leaflet.curve.

jayli3n avatar jayli3n commented on August 23, 2024

After some more testing, the lag stems from the fact that if you zoom into the map, the distance between point A and point B gets larger in terms of pixels, it then has to create more little dashed lines to cover the increased distance between point A and point B (since the length of each dash is constant).

Tested it with the code in this PR: #54
Instead of creating more little dashed lines, the PR keeps the number of dashed lines constant and makes each dashed line longer instead to cover the increased distance between point A and point B.

It will look like this now when zoomed in:

image

The PR fixes the lag, but makes the dashed lines look stretched out and weird. The lag is actually still there IF you create the line while you are already zoomed in.

from leaflet.curve.

jayli3n avatar jayli3n commented on August 23, 2024

Created a PR #57 to potentially fix this.

from leaflet.curve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.