Giter Club home page Giter Club logo

Comments (4)

rustyrussell avatar rustyrussell commented on June 4, 2024 1

I can't reproduce this. Which doesn't surprise me, since we don't really treat those strings at any point.

What are you paying with? Did it mess up somehow?

Here's my simple test:

def test_pay_offer_case_sensitive(node_factory, bitcoind):
    l1, l2 = node_factory.line_graph(2, opts={'experimental-offers': None})

    offer1 = l2.rpc.offer(amount='any', description='simple test')
    offer2 = l2.rpc.offer(amount='any', description='simple Test')

    assert l1.rpc.decode(offer1['bolt12'])['offer_description'] == 'simple test'
    assert l1.rpc.decode(offer2['bolt12'])['offer_description'] == 'simple Test'

    inv1 = l1.rpc.fetchinvoice(offer=offer1['bolt12'], amount_msat=100)
    inv2 = l1.rpc.fetchinvoice(offer=offer2['bolt12'], amount_msat=100)

    assert l1.rpc.decode(inv1['invoice'])['offer_description'] == 'simple test'
    assert l1.rpc.decode(inv2['invoice'])['offer_description'] == 'simple Test'

    l1.rpc.pay(inv1['invoice'])
    assert only_one(l2.rpc.listoffers(offer1['offer_id'])['offers'])['used'] is True
    assert only_one(l2.rpc.listoffers(offer2['offer_id'])['offers'])['used'] is False

from lightning.

farscapian avatar farscapian commented on June 4, 2024 1

Guys I am sorry waste your time on this. I was unable to replicate the issue on my side. I was certain at the time I had found a bug, but I apparently I had just confused myself. It's been known to happen.

from lightning.

vincenzopalazzo avatar vincenzopalazzo commented on June 4, 2024

yes @rustyrussell in Austin I wrote your same test and I was not able to reproduce, and I ask @farscapian to look the step to reproduce it

from lightning.

vincenzopalazzo avatar vincenzopalazzo commented on June 4, 2024

np was easy to write a test for it

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.