I was paying the following bolt12 offer on testnet and I get the following stack trace

Sounds like data in the following is <code class="not

I will try to do <a class="user-mention notranslate" data-hovercard-type="user" data-h

pay-plugin crash while paying an bolt12 offer about lightning HOT 2 OPEN

vincenzopalazzo commented on June 11, 2024

pay-plugin crash while paying an bolt12 offer

from lightning.

Comments (2)

cdecker commented on June 11, 2024

Sounds like data in the following is NULL:

lightning/common/json_stream.c

Lines 333 to 344 in d1101f4

 void json_add_hex(struct json_stream *js, const char *fieldname, 

 const void *data, size_t len) 

 { 

 /* Size without NUL term */ 

 size_t hexlen = hex_str_size(len); 

 char str[hexlen]; 

 if (!hex_encode(data, len, str, hexlen)) 

 abort(); 

 json_add_string(js, fieldname, str); 

 }

Can you set a breakpoint in json_add_hex and see if we are wrongly assuming the payment_secret is set in the returned invoice?

from lightning.

vincenzopalazzo commented on June 11, 2024

I will try to do @cdecker thanks

Currently I was able to reproduce it again

➜  ~ lightning-cli --testnet pay lni1qqgt2nsz6u6s37z2g48lhzq7kupusq3qgdyhl4lcy62hzz855v8annkr46a8n9eqsn5satgpagesjqqqqqqq5frpypjx2umrwf5hqarfdahzqargv96zq6npwdhkugrhd9kxcgryv43kjer9zcssymwjk4atqmpn9g9gue80xpcqxzsmmf0llqd04wj9e7cjgs5zu3862qsyxjtl6luzd9t3pr62xr7eemp6awnejusgf6gw45q75vcfqqqqqqzjqsae4jsqtqss8krllmhrpaznzeptkgv3h5ym94fvzwz8vler3hn3zfcle9c2lz2t5r3s88alsyc9ustu9t978wt2fy5uus9h7dfhwgqenkuacqgtr03u9p2nqtq84xmx4r9z4aglwdv7ycrgd4ygzv63zgvz9775qszuzfdmz93ksqsz2r83skraeef43j0qcjxk8lu9pe2ayvhnpflyrtz5k54xdl5vzjgsq28wc0a4quu22pjhkjw4pvgazjffrlhgn67gnav85utclvkdwl77ufd8jzhg279440cze0xpgmzk0fcwgkvc39tk9lf6d4s8gkwvtj69fyqe9uawph49cgvqqv423ysp5fn509ewu28ms6j7wv3haqedqn437l077qp3gu93llsjyncp6d4000e3kukpdnqe3nz7cp8lswazrsqqqqqqqqqq86qqqcqqqqqqqqqqqqqqqqqqpvxqqqqqqq9yq3jl7hlr4qsy8k4wdhk23htpvcthn9tcq3p3wzpqk56mwhydvy2c36d6dr2x6ed2qsae4jsqkqssymwjk4atqmpn9g9gue80xpcqxzsmmf0llqd04wj9e7cjgs5zu3867pqyeclmc6w0383har50rdf64upd7v9ut7ks5lztyn80wjwks9njujen9cmdpgycgdshkt4shphhaqj4yhsywv9689zrmcgzkm3ll0l7qu
pay: FATAL SIGNAL 11 (version v24.02.1)
0x5576bc52dd5e send_backtrace
	common/daemon.c:33
0x5576bc52dde6 crashdump
	common/daemon.c:75
0x7f2ae5d8004f ???
	???:0
0x5576bc582a90 ???
	???:0
0x5576bc53476e json_add_hex
	common/json_stream.c:340
0x5576bc535003 json_add_secret
	common/json_stream.c:641
0x5576bc5112c2 selfpay
	plugins/pay.c:836
0x5576bc51178b payment_listsendpays_previous
	plugins/pay.c:965
0x5576bc5179ce handle_rpc_reply
	plugins/libplugin.c:961
0x5576bc517b72 rpc_read_response_one
	plugins/libplugin.c:1148
0x5576bc517c1f rpc_conn_read_response
	plugins/libplugin.c:1172
0x5576bc6668fc next_plan
	ccan/ccan/io/io.c:59
0x5576bc666d83 do_plan
	ccan/ccan/io/io.c:407
0x5576bc666e1c io_ready
	ccan/ccan/io/io.c:417
0x5576bc668679 io_loop
	ccan/ccan/io/poll.c:453
0x5576bc517f9e plugin_main
	plugins/libplugin.c:2086
0x5576bc51365d main
	plugins/pay.c:1303
0x7f2ae5d6b249 ???
	???:0
0x7f2ae5d6b304 ???
	???:0
0x5576bc510790 ???
	???:0
0xffffffffffffffff ???
	???:0
{
   "code": -4,
   "message": "Plugin terminated before replying to RPC call."
}

from lightning.

pay-plugin crash while paying an bolt12 offer about lightning HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	void json_add_hex(struct json_stream js, const char fieldname,
	const void *data, size_t len)
	{
	/* Size without NUL term */
	size_t hexlen = hex_str_size(len);
	char str[hexlen];

	if (!hex_encode(data, len, str, hexlen))
	abort();

	json_add_string(js, fieldname, str);
	}