Giter Club home page Giter Club logo

Comments (10)

Sjors avatar Sjors commented on June 11, 2024 1

Good idea, I'll try that if it happens again.

from lightning.

Sjors avatar Sjors commented on June 11, 2024 1

Oh I guess --silent is in CARGO_OPTS? Will try that next time.

I did a git clean -dfx, ./configure ... after this to see what would happen. This time it built quickly.

from lightning.

Sjors avatar Sjors commented on June 11, 2024

Update: the installer finished after about 15 minutes total. If this can't be made faster, then at least I think it should be more verbose and show some progress.

from lightning.

vincenzopalazzo avatar vincenzopalazzo commented on June 11, 2024

I suspect that was was cargo build --quiet --bin ... to take long time? I have the same behavior

This can be caused if you change your rust version, and the recompilation of all the crates (that are a few) is trigger

from lightning.

Sjors avatar Sjors commented on June 11, 2024

The lightning user has its own rust installation. I didn't change it, but maybe CLN did?

Current version is cargo 1.67.1 (8ecd4f20a 2023-01-10)

from lightning.

daywalker90 avatar daywalker90 commented on June 11, 2024

i think i saw a commit for cln that updated the rust version and it might be that cargo updated its repo which takes a long time (git resolving deltas). I gave it a quick search and found this: rust-lang/cargo#11014

from lightning.

vincenzopalazzo avatar vincenzopalazzo commented on June 11, 2024

The lightning user has its own rust installation. I didn't change it, but maybe CLN did?

No, we did not, we do not force the rustc version at the moment but it is possible that cargo is rebuilding.

If this happens could you run a patch version of the Makefile where you remove the cargo build --silent and use just cargo build? I can make a patch for you if you like

from lightning.

Sjors avatar Sjors commented on June 11, 2024

It's being slow again while upgrading to v24.02, but I can't find the cargo build --silent line.

Cargo version before install: cargo 1.67.1

from lightning.

Sjors avatar Sjors commented on June 11, 2024

It was a bit faster than last time, only about 5 minutes. Cargo version after install is unchanged.

from lightning.

vincenzopalazzo avatar vincenzopalazzo commented on June 11, 2024

git grep returned some item

cln-rpc/Makefile:12:    cargo build ${CARGO_OPTS} --example cln-rpc-getinfo
cln-rpc/Makefile:15:    cargo build ${CARGO_OPTS} --example cln-plugin-startup
cln-rpc/Makefile:18:    cargo build ${CARGO_OPTS} --example cln-plugin-reentrant
plugins/Makefile:257:   cargo build ${CARGO_OPTS} --bin cln-grpc

Cargo version after install is unchanged.

The cln-rust library is changed in this case, causing rebuilding (maybe) but I do not know why it is taking all this time :/

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.