Comments (3)
There was an issue where negative values (ie -100) would be interpreted as a command named "100".
PR #6675 now special cases "-" followed by a digit as a numerical value instead of an unrecognized command.
from lightning.
The thinking was since you can only splice whole sat amounts and building signed the input types to use raw numbers was less effort / complication (sats / msats types do not allow negative values) , using raw signed values would work well for this. But perhaps that's worth reconsidering if it's breaking users' expectations.
from lightning.
Adding the --
technique usage example to the splice_init documentation in PR #6677.
from lightning.
Related Issues (20)
- docs/changelog: No mentions of clnrest.py docs or anything HOT 1
- [bug] createrune command crashes lightningd HOT 8
- Master not compiling on (ubuntu) linux HOT 1
- Unable to update database HOT 8
- Building master errors on OpenBSD 7.3 HOT 1
- splice: lightningd updates scid too early
- Backup: Add feature to verify backup HOT 2
- cln restart loop caused by fee overflow HOT 3
- hsmd: hsmd_ready_channel is confusing name HOT 3
- Allow non-strict forwarding HOT 2
- Problem with the gRPC on Debian 11.7 VMs in a proxmox cluster. HOT 3
- splice: need to sync with signer on funding locked HOT 6
- splice: signer must be informed of splice parameters HOT 4
- checkrune: when we pass an empty value for `method` parameter, it seems that `checkrune` return `{"valid": true}`
- lnprototest intermitted failure
- SQL RPC method for grpc
- waitblockheight rpc method missing in grpc
- Sendpay failing with WIRE_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS HOT 4
- Pagination for v23.11 HOT 1
- [Bug] plugin's htlc_accepted hook can't settle htlcs if channel force closes HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.