Comments (3)
jgriffiths
commented on June 11, 2024
Hi @benma, I have taken the approach of allowing 4 byte fingerprints to be passed if the full parent hash isn't available/desired. This keeps binary compatibility and allows use of the parent hash as more than a simple hint while supporting the 4 byte fingerprint.
Once this is merged and you update you can remove the final quirk from apps_common_bip32_xpub_from_protobuf in bitbix02-firmware by simply passing xpub_in->parent_fingerprint, sizeof(xpub_in->parent_fingerprint) directly.
from libwally-core.
jgriffiths
commented on June 11, 2024
Merged following code review, closing.
from libwally-core.
benma
commented on June 11, 2024
Excellent! Thank you.
from libwally-core.
Related Issues (20)
- WALLY_MINISCRIPT_REQUIRE_CHECKSUM flag missing in docs HOT 3
- Helper to serialise BIP32 path
- Improved debugging for wally_psbt_sign_bip32
- Add bitcoin as a topic to this repository
- test/test_transaction.py: test_hash_prevouts fails if libwallycore is built without SWIG and WASM HOT 3
- test/test_bip39.py: BIP39Tests.test_all_{langs,lookups} fail with --enable-standard-secp --enable-minimal HOT 2
- test/test_transaction.py: test_hash_prevouts fails with --disable-elements HOT 3
- Expose transaction accessors
- make check: test_clear fails HOT 1
- si_signo=SIGBUS si_code=BUS_ADRALN with linux kernel 6.1.21-v8+ aarch64 HOT 31
- bytes_len parameter in wally_addr_segwit_from_bytes function HOT 1
- psbt creation from scratch? HOT 3
- test/test_transaction.py: test_serialization fails if libwallycore is built without SWIG HOT 2
- Please expose compile time and runtime libwally versions HOT 11
- Help wanted with signing a native segwit transactions HOT 4
- why does bip39_get_word() use the heap -- can we have a function that returns a `const char*` instead? HOT 3
- Add bitcoin as a topic to this repository HOT 1
- Version info not working correctly HOT 2
- TypeError: createRequire is not a function if want to use wally in nextjs project HOT 2
- Build problems on stock Sonoma: "configure: error: Cannot find python in your system path" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libwally-core.